Project

General

Profile

Actions

Optimization #3829

open

pcap source: Counters, counters and... counters

Added by Roland Fischer almost 4 years ago. Updated 12 months ago.

Status:
New
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

There seem to be a lot of similar counters being tracked in source-pcap. Mentioned in #2845.

We shall revisit all the counters in source-pcap.

Comment from @victorjulien:

Also, we should consider the places where we count packets. I think I count 3 here: in livedev, in pkts/bytes and then in the stats api through capture_kernel*. And then we have of course the intermediate last_stats64 that you're introducing (for good reason). Thats a lot of stats keeping. W/o looking into why we do all this, my gut feel is that we can reduce some of this.

I agree that some of them seem redundant.

Actions

Also available in: Atom PDF