Project

General

Profile

Actions

Bug #3855

closed

mqtt: coverity static analysis issues

Added by Victor Julien over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

*** CID 1465604:  Null pointer dereferences  (REVERSE_INULL)
/src/detect-mqtt-flags.c: 192 in DetectMQTTFlagsParse()
186             flagv = strtok_r(NULL, ",", &xsaveptr);
187         }
188     
189         return de;
190     
191     error:
>>>     CID 1465604:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "de" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
192         if (de != NULL)
193             SCFree(de);
194         return NULL;
195     }
196     
197     /**

** CID 1465603:  Uninitialized variables  (UNINIT)
/src/detect-engine-uint.c: 376 in DetectU8Parse()

________________________________________________________________________________________________________
*** CID 1465603:  Uninitialized variables  (UNINIT)
/src/detect-engine-uint.c: 376 in DetectU8Parse()
370             }
371         }
372         u8d = SCCalloc(1, sizeof (DetectU8Data));
373         if (unlikely(u8d == NULL))
374             return NULL;
375         u8d->arg1 = u8da.arg1;
>>>     CID 1465603:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "u8da.arg2".
376         u8d->arg2 = u8da.arg2;
377         u8d->mode = u8da.mode;
378     
379         return u8d;

** CID 1465602:  Null pointer dereferences  (REVERSE_INULL)
/src/detect-mqtt-connack-sessionpresent.c: 157 in DetectMQTTConnackSessionPresentParse()

________________________________________________________________________________________________________
*** CID 1465602:  Null pointer dereferences  (REVERSE_INULL)
/src/detect-mqtt-connack-sessionpresent.c: 157 in DetectMQTTConnackSessionPresentParse()
151             goto error;
152         }
153     
154         return de;
155     
156     error:
>>>     CID 1465602:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "de" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
157         if (de != NULL)
158             SCFree(de);
159         return NULL;
160     }
161     
162     /**

** CID 1465601:  Null pointer dereferences  (REVERSE_INULL)
/src/detect-mqtt-connect-flags.c: 212 in DetectMQTTConnectFlagsParse()

________________________________________________________________________________________________________
*** CID 1465601:  Null pointer dereferences  (REVERSE_INULL)
/src/detect-mqtt-connect-flags.c: 212 in DetectMQTTConnectFlagsParse()
206             flagv = strtok_r(NULL, ",", &xsaveptr);
207         }
208     
209         return de;
210     
211     error:
>>>     CID 1465601:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "de" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
212         if (de != NULL)
213             SCFree(de);
214         return NULL;
215     }
216     
217     /**
Actions

Also available in: Atom PDF