Actions
Optimization #3973
closedSuricata-Verify: Convert "cmp" tests to Python
Effort:
Difficulty:
Label:
Beginner
Description
Some tests use a check.sh script to run "cmp" on 2 files to check that they are the same. This could be converted to an internal check and become part of test.yaml.
Example test: output-tcp-data
Possible YAML syntax for test.yaml:
checks: - file-compare: filename: tcp-data.log expected: expected/tcp-data.log
This will require run.py to parse this kind of test, then do the file comparison internally. It looks like the standard library has a filecmp module which may be useful for this.
Updated by Shivani Bhardwaj about 4 years ago
- Assignee set to Community Ticket
- Target version set to QA
Updated by Jason Ish about 4 years ago
- Subject changed from Suricata-Verify: Conver "cmp" tests to Python to Suricata-Verify: Convert "cmp" tests to Python
Updated by Tharushi Jayasekara almost 4 years ago
- Assignee changed from Community Ticket to Tharushi Jayasekara
Updated by Jason Ish almost 4 years ago
- Status changed from New to In Review
Updated by Jason Ish over 3 years ago
Merged. Finally! https://github.com/OISF/suricata-verify/pull/447
Actions