Project

General

Profile

Actions

Optimization #3973

closed

Suricata-Verify: Convert "cmp" tests to Python

Added by Jason Ish about 1 year ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:
Beginner

Description

Some tests use a check.sh script to run "cmp" on 2 files to check that they are the same. This could be converted to an internal check and become part of test.yaml.

Example test: output-tcp-data

Possible YAML syntax for test.yaml:

checks:
  - file-compare:
      filename: tcp-data.log
      expected: expected/tcp-data.log

This will require run.py to parse this kind of test, then do the file comparison internally. It looks like the standard library has a filecmp module which may be useful for this.

Actions #1

Updated by Shivani Bhardwaj about 1 year ago

  • Assignee set to Community Ticket
  • Target version set to QA
Actions #2

Updated by Jason Ish 12 months ago

  • Subject changed from Suricata-Verify: Conver "cmp" tests to Python to Suricata-Verify: Convert "cmp" tests to Python
Actions #3

Updated by Tharushi Jayasekara 10 months ago

  • Assignee changed from Community Ticket to Tharushi Jayasekara
Actions #4

Updated by Jason Ish 8 months ago

  • Status changed from New to In Review
Actions #6

Updated by Jason Ish 3 months ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF