Project

General

Profile

Actions

Optimization #3973

closed
JI TJ

Suricata-Verify: Convert "cmp" tests to Python

Optimization #3973: Suricata-Verify: Convert "cmp" tests to Python

Added by Jason Ish over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:
Beginner

Description

Some tests use a check.sh script to run "cmp" on 2 files to check that they are the same. This could be converted to an internal check and become part of test.yaml.

Example test: output-tcp-data

Possible YAML syntax for test.yaml:

checks:
  - file-compare:
      filename: tcp-data.log
      expected: expected/tcp-data.log

This will require run.py to parse this kind of test, then do the file comparison internally. It looks like the standard library has a filecmp module which may be useful for this.

SB Updated by Shivani Bhardwaj over 5 years ago Actions #1

  • Assignee set to Community Ticket
  • Target version set to QA

JI Updated by Jason Ish over 5 years ago Actions #2

  • Subject changed from Suricata-Verify: Conver "cmp" tests to Python to Suricata-Verify: Convert "cmp" tests to Python

TJ Updated by Tharushi Jayasekara over 5 years ago Actions #3

  • Assignee changed from Community Ticket to Tharushi Jayasekara

JI Updated by Jason Ish about 5 years ago Actions #4

  • Status changed from New to In Review

JI Updated by Jason Ish almost 5 years ago Actions #6

  • Status changed from In Review to Closed
Actions

Also available in: PDF Atom