Project

General

Profile

Actions
Copy link

Feature #4060

closed
SB TJ

createst: Commandline param to specify minimum required version of Suricata

Feature #4060: createst: Commandline param to specify minimum required version of Suricata

Added by Shivani Bhardwaj over 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tharushi Jayasekara
Target version:
QA
Effort:
Difficulty:
Label:
Beginner, Outreachy, Python

Description

Current createst script generates only the filter blocks as per eve.json, extend its functionality to add a global minimum required version of Suricata as mentioned on command line.

Expectation

createst.py mytest mypcap --add-min-version 5.0

The final generated test.yaml should have a min suricata version defined globally. e.g. https://github.com/OISF/suricata-verify/blob/master/tests/flowbit-oring/test.yaml

SB Updated by Shivani Bhardwaj over 5 years ago Actions
Copy link
 #1

  • Description updated (diff)

SB Updated by Shivani Bhardwaj over 5 years ago Actions
Copy link
 #2

  • Target version set to QA

AJ Updated by Anuradha jha over 5 years ago Actions
Copy link
 #3

  • Assignee changed from Community Ticket to Anuradha jha

AJ Updated by Anuradha jha over 5 years ago Actions
Copy link
 #4

  • Assignee changed from Anuradha jha to Community Ticket

TJ Updated by Tharushi Jayasekara over 5 years ago Actions
Copy link
 #5

  • Assignee changed from Community Ticket to Tharushi Jayasekara

TJ Updated by Tharushi Jayasekara over 5 years ago Actions
Copy link
 #6

Shivani Bhardwaj wrote:

Current createst script generates only the filter blocks as per eve.json, extend its functionality to add a global minimum required version of Suricata as mentioned on command line.

Expectation

[...]

The final generated test.yaml should have a min suricata version defined globally. e.g. https://github.com/OISF/suricata-verify/blob/master/tests/flowbit-oring/test.yaml

Hi Shivani,

Just a small question regarding the wording of the commandline param. Could I change it to "min-version" so that the it is consistent with the existing params, or should I use "add-min-version" as given in the text?

TJ Updated by Tharushi Jayasekara over 5 years ago Actions
Copy link
 #7

  • Status changed from New to In Review

JF Updated by Juliana Fajardini Reichow over 3 years ago Actions
Copy link
 #8

  • Status changed from In Review to Closed

PR was merged.

Actions
Copy link

Also available in: PDF Atom