Suricata

In util-debug.h
Could you modify
#define SCReturnInt(x) do { \
if (sc_log_global_log_level >= SC_LOG_DEBUG) { \
SCLogDebug("Returning: %d ... <<", x); \
SCLogCheckFDFilterExit(FUNCTION); \
} \
return x; \
} while(0)

To look like this (NOTE the only difference is the inclusion of the 't'.

#define SCReturnInt(x) do { \
if (sc_log_global_log_level >= SC_LOG_DEBUG) { \
SCLogDebug("Returning: %td ... <<", x); \
SCLogCheckFDFilterExit(FUNCTION); \
} \
return x; \
} while(0)

In C99, such code can use %td; the t size modifier corresponds to the
ptrdiff_t type.

If that works, let me know and I will do a submit a correct patch. If it doesn't work, I will create a SCReturnLongInt() macro and cast the
difference to a long and use %ld

It does solve the issue there, but there is the other issue of passing an int:

cc1: warnings being treated as errors
flow.c: In function ‘FlowClearMemory’:
flow.c:747: error: format ‘%td’ expects type ‘ptrdiff_t’, but argument 4 has type ‘int’
flow.c:747: error: format ‘%td’ expects type ‘ptrdiff_t’, but argument 4 has type ‘int’

While this may solve the warning for the debug output, I think the real issue is that the function returns "int" and you are passing a "long int" in the return macro. Probably better would be to do proper casting instead of assuming that it is an int? Though the issue is not there w/o debug because the compiler sees that it needs to be an int in the return. I prefer casts, which shows that the programmer knows the issue is there.

Grr. Wait. Another patch coming soon :)

Wouldn't it make more sense to use a fixed size type like uint32_t?

Kirby: That patch does indeed remove the warnings for me, however...

Victor: Agreed, uint32_t seems adequate (providing no negative returns). Though "int" seems fine as well, given proper handling/casts. Or maybe just use ptrdiff_t, but there is no return Macro for this.

That last patch works for me as well (I like it better).

After applying the patch the unittest DCERPCParserTest01 gets stuck an an endless loop.