Actions
Optimization #4517
opencbindgen export the constants from Rust to C, also for macro such as BIT_U8(1), and remove duplicate definitions between rust and C
Effort:
Difficulty:
Label:
Description
So that we do not have 2 definitions on the 2 sides
Which can end up having a different value
cf https://github.com/OISF/suricata/pull/6168
That is the line item_types = ["enums","structs","opaque","functions"] in rust/cbindgen.toml
cbindgen doesn't like our BIT_ macros, maybe there is a work-around, maybe not. In Rust bit flags are often written out like 0b00000001.
This would lead us more to a big super include. Should we care? I noticed I can run cbindgen aginst particular .rs files to make more granular header files which might be something to explore as well...
Updated by Philippe Antoine about 3 years ago
- Related to Bug #5012: Remove duplicate definition of constants between C and Rust added
Updated by Philippe Antoine about 2 years ago
Cinstants are exported but APP_LAYER_PARSER_NO_INSPECTION_PAYLOAD defined by a macro is not
Updated by Philippe Antoine about 2 years ago
- Subject changed from cbindgen export the constants from Rust to C to cbindgen export the constants from Rust to C, also for macro such as BIT_U8(1)
Updated by Philippe Antoine about 2 years ago
- Subject changed from cbindgen export the constants from Rust to C, also for macro such as BIT_U8(1) to cbindgen export the constants from Rust to C, also for macro such as BIT_U8(1), and remove duplicate definitions between rust and C
Updated by Philippe Antoine about 1 year ago
I think this optimization can be postponed after 8
Updated by Victor Julien 6 months ago
- Target version changed from 8.0.0-beta1 to 9.0.0-beta1
Actions