Project

General

Profile

Actions

Bug #5012

closed

Remove duplicate definition of constants between C and Rust

Added by Philippe Antoine over 1 year ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

Discussion comes from https://github.com/OISF/suricata/pull/6840

PGSQL_LOG_PASSWORDS is not exported by cbindgen

With the following patch

-pub const PGSQL_LOG_PASSWORDS: u32 = BIT_U32!(1);
+pub const PGSQL_LOG_PASSWORDS: u32 = 2;

it does get exported

FLOW_DIR_REVERSED is another example

CI should ensure this get no longer added


Related issues 2 (1 open1 closed)

Related to Suricata - Bug #5007: pgsql: coverity warningClosedJuliana Fajardini ReichowActions
Related to Suricata - Optimization #4517: cbindgen export the constants from Rust to C, also for macro such as BIT_U8(1), and remove duplicate definitions between rust and CNewOISF DevActions
Actions #1

Updated by Juliana Fajardini Reichow over 1 year ago

  • Related to Bug #5007: pgsql: coverity warning added
Actions #3

Updated by Philippe Antoine over 1 year ago

  • Priority changed from Normal to Low
Actions #4

Updated by Philippe Antoine over 1 year ago

  • Priority changed from Low to Normal
  • Target version changed from 7.0.0-beta1 to TBD
Actions #5

Updated by Philippe Antoine over 1 year ago

  • Related to Optimization #4517: cbindgen export the constants from Rust to C, also for macro such as BIT_U8(1), and remove duplicate definitions between rust and C added
Actions #6

Updated by Philippe Antoine 3 months ago

Looks like the best is to get rid of rust `BIT_U` macros

Actions #7

Updated by Philippe Antoine 3 months ago

Or maybe have a dummy cbindgen-like which does the headers for BIT_U macros...

Actions #8

Updated by Philippe Antoine 3 months ago

  • Status changed from New to Closed

To be done with #4517

Actions

Also available in: Atom PDF