Project

General

Profile

Actions

Bug #4530

open

DOS Quadratic complexity when having too many transactions

Added by Philippe Antoine 4 months ago. Updated 8 days ago.

Status:
In Review
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

Kind of found by oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35195

This is true for protocols such as MQTT, Modbus or HTTP2, where each packet/PDU has a transaction identifier (called stream for HTTP2), and we loop over our whole list of transactions to find the right one.
Attack si to start many requests, and do not finish them, so that Suricata keeps them.

There may be more protocols


Related issues

Related to Task #4721: http2: enable by defaultClosedPhilippe AntoineActions
Actions #1

Updated by Philippe Antoine 4 months ago

  • Status changed from New to In Review

Gitlab

Actions #2

Updated by Philippe Antoine 4 months ago

  • Private changed from Yes to No
Actions #3

Updated by Philippe Antoine 20 days ago

  • Related to Task #4721: http2: enable by default added
Actions #5

Updated by Philippe Antoine 8 days ago

Another fix could be to have a hash table instead of a list for transactions for MQTT and such...

Actions

Also available in: Atom PDF