Project

General

Profile

Actions

Bug #4577

closed

coverity: minor warnings

Added by Victor Julien over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

*** CID 1489782:  Error handling issues  (CHECKED_RETURN)
/src/stream-tcp-reassemble.c: 381 in StreamTcpReassemblyConfig()
375         }
376         if (!quiet)
377             SCLogConfig("stream.reassembly \"segment-prealloc\": %u", segment_prealloc);
378         stream_config.prealloc_segments = segment_prealloc;
379     
380         int overlap_diff_data = 0;
>>>     CID 1489782:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "ConfGetBool" without checking return value (as is done elsewhere 28 out of 35 times).
381         ConfGetBool("stream.reassembly.check-overlap-different-data", &overlap_diff_data);
382         if (overlap_diff_data) {
383             StreamTcpReassembleConfigEnableOverlapCheck();
384         }
385         if (StreamTcpInlineMode() == TRUE) {
386             StreamTcpReassembleConfigEnableOverlapCheck();

** CID 1489781:    (CHECKED_RETURN)
/src/runmodes.c: 856 in RunModeInitializeOutputs()
/src/runmodes.c: 824 in RunModeInitializeOutputs()

________________________________________________________________________________________________________
*** CID 1489781:    (CHECKED_RETURN)
/src/runmodes.c: 856 in RunModeInitializeOutputs()
850                 } else {
851                     AddOutputToFreeList(module, output_ctx);
852                     SetupOutput(module->name, module, output_ctx);
853                 }
854             }
855             if (count == 0) {
>>>     CID 1489781:    (CHECKED_RETURN)
>>>     Calling "ConfGetBool" without checking return value (as is done elsewhere 28 out of 35 times).
856                 FatalErrorOnInit(SC_ERR_INVALID_ARGUMENT,
857                     "No output module named %s", output->val);
858                 continue;
859             }
860         }
861     
/src/runmodes.c: 824 in RunModeInitializeOutputs()
818                 count++;
819     
820                 OutputCtx *output_ctx = NULL;
821                 if (module->InitFunc != NULL) {
822                     OutputInitResult r = module->InitFunc(output_config);
823                     if (!r.ok) {
>>>     CID 1489781:    (CHECKED_RETURN)
>>>     Calling "ConfGetBool" without checking return value (as is done elsewhere 28 out of 35 times).
824                         FatalErrorOnInit(SC_ERR_INVALID_ARGUMENT,
825                             "output module \"%s\": setup failed", output->val);
826                         continue;
827                     } else if (r.ctx == NULL) {
828                         continue;
829                     }

** CID 400492:    (CHECKED_RETURN)
/src/stream-tcp.c: 422 in StreamTcpInitConfig()
/src/stream-tcp.c: 429 in StreamTcpInitConfig()

________________________________________________________________________________________________________
*** CID 400492:    (CHECKED_RETURN)
/src/stream-tcp.c: 422 in StreamTcpInitConfig()
416     
417         if (!quiet) {
418             SCLogConfig("stream \"memcap\": %"PRIu64, SC_ATOMIC_GET(stream_config.memcap));
419         }
420     
421         int imidstream;
>>>     CID 400492:    (CHECKED_RETURN)
>>>     Calling "ConfGetBool" without checking return value (as is done elsewhere 28 out of 35 times).
422         ConfGetBool("stream.midstream", &imidstream);
423         stream_config.midstream = imidstream != 0;
424     
425         if (!quiet) {
426             SCLogConfig("stream \"midstream\" session pickups: %s", stream_config.midstream ? "enabled" : "disabled");
427         }
/src/stream-tcp.c: 429 in StreamTcpInitConfig()
423         stream_config.midstream = imidstream != 0;
424     
425         if (!quiet) {
426             SCLogConfig("stream \"midstream\" session pickups: %s", stream_config.midstream ? "enabled" : "disabled");
427         }
428     
>>>     CID 400492:    (CHECKED_RETURN)
>>>     Calling "ConfGetBool" without checking return value (as is done elsewhere 28 out of 35 times).
429         ConfGetBool("stream.async-oneside", &stream_config.async_oneside);
430     
431         if (!quiet) {
432             SCLogConfig("stream \"async-oneside\": %s", stream_config.async_oneside ? "enabled" : "disabled");
433         }
434     
Actions #1

Updated by Juliana Fajardini Reichow over 1 year ago

  • Status changed from Assigned to In Progress
Actions #3

Updated by Juliana Fajardini Reichow over 1 year ago

  • Status changed from In Progress to In Review
Actions #4

Updated by Juliana Fajardini Reichow over 1 year ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF