Project

General

Custom queries

Profile

Actions

Optimization #4748

closed

Optimization #4747: app-layer: make tx iterator a mandatory part of the API

app-layer/rust: explore if tx iterator can be implemented as a trait

Added by Victor Julien about 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Effort:
Difficulty:
Label:

Description

It seems all the iterators are similar, except for the type.

Actions #1

Updated by Jason Ish about 3 years ago

Updated my PR to include SMB for testing purposes:

https://github.com/OISF/suricata/pull/6519

But I'm wondering, if they're all the same, what does this provide over AppLayerDefaultGetTxIterator?

Actions #2

Updated by Jason Ish over 2 years ago

  • Status changed from New to Closed
  • Assignee set to Jason Ish
  • Target version set to 7.0.0-beta1

Yes, for 7.0 using a generic iterator in Rust has worked well I think.

Actions

Also available in: Atom PDF