Actions
Optimization #4795
closed
JF
JF
Remove PASS_IF macro from the FAIL/PASS API
Optimization #4795:
Remove PASS_IF macro from the FAIL/PASS API
Effort:
Difficulty:
Label:
C
Description
According to the discussion in this PR https://github.com/OISF/suricata/pull/5485
it was agreed that having a PASS_IF macro could lead to unittests checks that would
not have the PASS as the final call, or to the test-writing logic having to be reverted
to write the PASS_IF, after all the FAIL_IF checks.
Adding a ticket to keep this well documented/tracked.
JF Updated by Juliana Fajardini Reichow over 4 years ago
- Related to Optimization #4066: Add a PASS_IF_NULL macro to the FAIL/PASS API added
JF Updated by Juliana Fajardini Reichow over 4 years ago
- Status changed from In Progress to In Review
PR for review: https://github.com/OISF/suricata/pull/6546
JF Updated by Juliana Fajardini Reichow over 4 years ago
- Status changed from In Review to Closed
Actions