Project

General

Profile

Actions
Copy link

Optimization #4795

closed

Remove PASS_IF macro from the FAIL/PASS API

Added by Juliana Fajardini Reichow about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Juliana Fajardini Reichow
Target version:
7.0.0-beta1
Effort:
Difficulty:
Label:
C

Description

According to the discussion in this PR https://github.com/OISF/suricata/pull/5485
it was agreed that having a PASS_IF macro could lead to unittests checks that would
not have the PASS as the final call, or to the test-writing logic having to be reverted
to write the PASS_IF, after all the FAIL_IF checks.

Adding a ticket to keep this well documented/tracked.

Related issues 1 (0 open — 1 closed)

Related to Suricata - Optimization #4066: Add a PASS_IF_NULL macro to the FAIL/PASS APIClosedJanani RamjeeActions
Actions
Copy link

Also available in: Atom PDF