Project

General

Profile

Actions

Optimization #4795

closed

Remove PASS_IF macro from the FAIL/PASS API

Added by Juliana Fajardini Reichow about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:
C

Description

According to the discussion in this PR https://github.com/OISF/suricata/pull/5485
it was agreed that having a PASS_IF macro could lead to unittests checks that would
not have the PASS as the final call, or to the test-writing logic having to be reverted
to write the PASS_IF, after all the FAIL_IF checks.

Adding a ticket to keep this well documented/tracked.


Related issues 1 (0 open1 closed)

Related to Optimization #4066: Add a PASS_IF_NULL macro to the FAIL/PASS APIClosedJanani RamjeeActions
Actions #1

Updated by Juliana Fajardini Reichow about 1 year ago

Actions #2

Updated by Juliana Fajardini Reichow about 1 year ago

  • Status changed from In Progress to In Review
Actions #3

Updated by Juliana Fajardini Reichow about 1 year ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF