Project

General

Profile

Actions
Copy link

Bug #4899

closed
JI JI

suricata-verify: exceptions caused by code errors can be silently ignored

Bug #4899: suricata-verify: exceptions caused by code errors can be silently ignored

Added by Jason Ish over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Jason Ish
Target version:
QA
Affected Versions:
Effort:
Difficulty:
Label:

Description

If you look the code change in this Suricata-Verify pull request, https://github.com/OISF/suricata-verify/pull/605/files, it looks like this should cause a runtime error as its calling a function that doesn't exist. However, in the exception handling this type of error is being silently absorbed.

The result is that tests that trigger this code path are not even displayed in the S-V output, and are not recorded as failures.

Ideally code errors like this should just have their exceptions raised to the top so the failure is spectacular.

SB Updated by Shivani Bhardwaj over 4 years ago Actions
Copy link
 #1

  • Status changed from New to Assigned
  • Priority changed from Normal to Urgent

SB Updated by Shivani Bhardwaj over 4 years ago Actions
Copy link
 #2

  • Target version set to QA

SB Updated by Shivani Bhardwaj over 4 years ago Actions
Copy link
 #3

  • Status changed from Assigned to In Review

SB Updated by Shivani Bhardwaj over 4 years ago Actions
Copy link
 #4

  • Status changed from In Review to Closed
  • Assignee changed from Shivani Bhardwaj to Jason Ish
Actions
Copy link

Also available in: PDF Atom