Project

General

Profile

Actions

Optimization #4908

closed

ftp: use AppLayerResult instead of buffering wherever possible

Added by Shivani Bhardwaj about 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

Use AppLayerResult https://github.com/OISF/suricata/blob/master/src/app-layer-parser.h#L84-L98 instead of buffering the data.
If the length of the required incomplete data is not known, return 1 from AppLayerResult::incomplete to indicate that at least one more byte is required by the parser if it's available.


Related issues 2 (1 open1 closed)

Related to Suricata - Optimization #4907: smtp: use AppLayerResult instead of buffering wherever possibleClosedShivani BhardwajActions
Blocks Suricata - Feature #4906: ftp: add stream app-layer frame support AssignedShivani BhardwajActions
Actions #1

Updated by Victor Julien about 2 years ago

  • Related to Optimization #4907: smtp: use AppLayerResult instead of buffering wherever possible added
Actions #2

Updated by Victor Julien about 2 years ago

  • Blocks Feature #4906: ftp: add stream app-layer frame support added
Actions #3

Updated by Sam Mohammad about 2 years ago

  • Status changed from Assigned to In Progress
Actions #4

Updated by Victor Julien almost 2 years ago

  • Status changed from In Progress to Assigned
  • Assignee changed from Sam Mohammad to Shivani Bhardwaj
Actions #5

Updated by Shivani Bhardwaj over 1 year ago

  • Status changed from Assigned to In Progress
Actions #6

Updated by Victor Julien over 1 year ago

  • Target version changed from 7.0.0-beta1 to 7.0.0-rc1
Actions #7

Updated by Victor Julien about 1 year ago

  • Target version changed from 7.0.0-rc1 to 8.0.0-beta1
Actions #8

Updated by Shivani Bhardwaj about 1 year ago

  • Status changed from In Progress to In Review
Actions #9

Updated by Shivani Bhardwaj about 1 year ago

  • Target version changed from 8.0.0-beta1 to 7.0.0-rc1
Actions #10

Updated by Shivani Bhardwaj about 1 year ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF