Project

General

Profile

Actions

Optimization #4908

closed
SB SB

ftp: use AppLayerResult instead of buffering wherever possible

Optimization #4908: ftp: use AppLayerResult instead of buffering wherever possible

Added by Shivani Bhardwaj over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

Use AppLayerResult https://github.com/OISF/suricata/blob/master/src/app-layer-parser.h#L84-L98 instead of buffering the data.
If the length of the required incomplete data is not known, return 1 from AppLayerResult::incomplete to indicate that at least one more byte is required by the parser if it's available.


Related issues 2 (1 open1 closed)

Related to Suricata - Optimization #4907: smtp: use AppLayerResult instead of buffering wherever possibleClosedShivani BhardwajActions
Blocks Suricata - Feature #4906: ftp: add stream app-layer frame support AssignedOISF DevActions

VJ Updated by Victor Julien over 4 years ago Actions #1

  • Related to Optimization #4907: smtp: use AppLayerResult instead of buffering wherever possible added

VJ Updated by Victor Julien over 4 years ago Actions #2

  • Blocks Feature #4906: ftp: add stream app-layer frame support added

SM Updated by Sam Mohammad about 4 years ago Actions #3

  • Status changed from Assigned to In Progress

VJ Updated by Victor Julien about 4 years ago Actions #4

  • Status changed from In Progress to Assigned
  • Assignee changed from Sam Mohammad to Shivani Bhardwaj

SB Updated by Shivani Bhardwaj over 3 years ago Actions #5

  • Status changed from Assigned to In Progress

VJ Updated by Victor Julien over 3 years ago Actions #6

  • Target version changed from 7.0.0-beta1 to 7.0.0-rc1

VJ Updated by Victor Julien over 3 years ago Actions #7

  • Target version changed from 7.0.0-rc1 to 8.0.0-beta1

SB Updated by Shivani Bhardwaj over 3 years ago Actions #8

  • Status changed from In Progress to In Review

SB Updated by Shivani Bhardwaj over 3 years ago Actions #9

  • Target version changed from 8.0.0-beta1 to 7.0.0-rc1

SB Updated by Shivani Bhardwaj over 3 years ago Actions #10

  • Status changed from In Review to Closed
Actions

Also available in: PDF Atom