Optimization #4907: smtp: use AppLayerResult instead of buffering wherever possible - Suricata - Open Information Security Foundation

Actions

Copy link

Optimization #4907

closed

smtp: use AppLayerResult instead of buffering wherever possible

Added by Shivani Bhardwaj about 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Shivani Bhardwaj

Target version:

7.0.0-beta1

Effort:

Difficulty:

Label:

Description

Use AppLayerResult https://github.com/OISF/suricata/blob/master/src/app-layer-parser.h#L84-L98 instead of buffering the data.
If the length of the required incomplete data is not known, return 1 from AppLayerResult::incomplete to indicate that at least one more byte is required by the parser if it's available.

Related issues 2 (0 open — 2 closed)