Project

General

Profile

Actions

Feature #4946

open
VJ OD

nfsv2: implement WRITE support

Feature #4946: nfsv2: implement WRITE support

Added by Victor Julien over 4 years ago. Updated 3 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Target version:
Effort:
Difficulty:
Label:
Beginner, Protocol, Rust

Description

Needed for to_server file.data, file logging and extraction.


Related issues 1 (0 open1 closed)

Blocked by Suricata - Feature #8222: nfs: log detailed response for versions other than v3ClosedPhilippe AntoineActions

VJ Updated by Victor Julien almost 3 years ago Actions #1

  • Assignee set to Community Ticket
  • Target version set to TBD
  • Label Beginner, Good First Issue, Protocol, Rust added

LO Updated by Liza Opar over 2 years ago Actions #2

  • Assignee changed from Community Ticket to Liza Opar

LO Updated by Liza Opar over 2 years ago Actions #3

  • Assignee deleted (Liza Opar)

JF Updated by Juliana Fajardini Reichow about 2 years ago Actions #4

  • Assignee set to Community Ticket

JF Updated by Juliana Fajardini Reichow about 2 years ago Actions #5

  • Target version changed from TBD to 8.0.0-beta1

SM Updated by Sam Mohammad about 2 years ago Actions #6

I'd love to work this ticket!

JF Updated by Juliana Fajardini Reichow about 2 years ago Actions #7

Sam Muhammed wrote in #note-6:

I'd love to work this ticket!

Please, assign it to yourself, thank you, and happy to see some contributions from you! :)

SM Updated by Sam Mohammad about 2 years ago Actions #8

  • Assignee changed from Community Ticket to Sam Mohammad

SM Updated by Sam Mohammad about 2 years ago Actions #9

  • Status changed from New to Assigned

VJ Updated by Victor Julien about 1 year ago Actions #10

  • Status changed from Assigned to New
  • Assignee changed from Sam Mohammad to Community Ticket
  • Target version changed from 8.0.0-beta1 to 9.0.0-beta1

JK Updated by James Kaddu 6 months ago Actions #11

  • Status changed from New to In Progress
  • Assignee changed from Community Ticket to James Kaddu

hello, currently working on this. Thanks

JK Updated by James Kaddu 6 months ago ยท Edited Actions #12

  • Status changed from In Progress to In Review

JF Updated by Juliana Fajardini Reichow 5 months ago Actions #13

  • Status changed from In Review to New
  • Assignee changed from James Kaddu to Community Ticket

Hi there, according to our guidelines for stale tickets, I'm un-assigning this ticket.

PR marked as stale: https://github.com/OISF/suricata/pull/14251

Thanks for your interest in our project, and feel free to reach out in case you have time and want to contribute to Suricata again :) :)

Refer to:
https://forum.suricata.io/t/important-outreachy-contribution-phase-wrap-up-prs-claimed-tickets-and-more
https://docs.suricata.io/en/latest/devguide/codebase/contributing/contribution-process.html#stale-tickets-policy

JF Updated by Juliana Fajardini Reichow 5 months ago Actions #14

  • Label deleted (Good First Issue)

OF Updated by Olusegun Fajobi 5 months ago Actions #15

  • Assignee changed from Community Ticket to Olusegun Fajobi

OF Updated by Olusegun Fajobi 5 months ago Actions #16

  • Status changed from New to In Progress

PA Updated by Philippe Antoine 4 months ago Actions #17

  • Assignee changed from Olusegun Fajobi to Philippe Antoine

PA Updated by Philippe Antoine 4 months ago Actions #18

nfs_log_response does not handle v4
SCNfsTxLoggingIsFiltered does not handle v4

Looks like there is much to do...

PA Updated by Philippe Antoine 3 months ago Actions #20

Philippe Antoine wrote in #note-18:

nfs_log_response does not handle v4
SCNfsTxLoggingIsFiltered does not handle v4

Looks like there is much to do...

Need to create new ticket(s)

PA Updated by Philippe Antoine 3 months ago Actions #21

  • Blocked by Feature #8222: nfs: log detailed response for versions other than v3 added

PA Updated by Philippe Antoine 3 months ago Actions #22

Philippe Antoine wrote in #note-20:

SCNfsTxLoggingIsFiltered does not handle v4

Well, there is a TODO comment to make this configurable
The code is now correct for v2 and v3

PA Updated by Philippe Antoine 3 months ago Actions #23

  • Assignee changed from Philippe Antoine to OISF Dev

Unassigning myself : it looks like there is much work to do even if there was a PR : first understand how NFSv2 writes a file (can it do so in multiple PDUs)

Actions

Also available in: PDF Atom