Project

General

Profile

Actions

Optimization #4950

open

Code improvement in KRB5State.parse function

Added by Eloy Pérez about 4 years ago. Updated about 14 hours ago.

Status:
Assigned
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:
Rust

Description

The function KRB5State.parse function requires a couple of improvements in code readability:

- Giving meaningful names to the kerberos message types, probably the MessageType struct defined in krb5_constants.rs could be used for this

- Rename the KRB5State.req_id to KRB5State.req_type, since it is used to track the request type (AS-REQ, TGS-REQ, etc), not an unique id per request, and its name is misleading


Related issues 1 (1 open0 closed)

Related to Suricata - Optimization #3540: krb5: use app-layer incomplete supportAssignedPierre ChifflierActions
Actions #1

Updated by Victor Julien over 3 years ago

  • Target version changed from 7.0.0-beta1 to 7.0.0-rc1
Actions #2

Updated by Victor Julien about 3 years ago

  • Target version changed from 7.0.0-rc1 to 8.0.0-beta1
Actions #3

Updated by Victor Julien about 1 year ago

  • Target version changed from 8.0.0-beta1 to 9.0.0-beta1
Actions #4

Updated by Philippe Antoine about 14 hours ago

  • Status changed from New to Assigned
Actions #5

Updated by Philippe Antoine about 14 hours ago

Actions

Also available in: Atom PDF