Project

General

Profile

Actions
Copy link

Optimization #4950

open
EP PC

Code improvement in KRB5State.parse function

Optimization #4950: Code improvement in KRB5State.parse function

Added by Eloy Pérez about 4 years ago. Updated about 2 months ago.

Status:
Assigned
Priority:
Normal
Assignee:
Pierre Chifflier
Target version:
9.0.0-beta1
Effort:
Difficulty:
Label:
Rust

Description

The function KRB5State.parse function requires a couple of improvements in code readability:

- Giving meaningful names to the kerberos message types, probably the MessageType struct defined in krb5_constants.rs could be used for this

- Rename the KRB5State.req_id to KRB5State.req_type, since it is used to track the request type (AS-REQ, TGS-REQ, etc), not an unique id per request, and its name is misleading

Related issues 1 (0 open — 1 closed)

Related to Suricata - Optimization #3540: krb5: use app-layer incomplete supportClosedPhilippe AntoineActions

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
 #1

  • Target version changed from 7.0.0-beta1 to 7.0.0-rc1

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
 #2

  • Target version changed from 7.0.0-rc1 to 8.0.0-beta1

VJ Updated by Victor Julien about 1 year ago Actions
Copy link
 #3

  • Target version changed from 8.0.0-beta1 to 9.0.0-beta1

PA Updated by Philippe Antoine about 2 months ago Actions
Copy link
 #4

  • Status changed from New to Assigned

PA Updated by Philippe Antoine about 2 months ago Actions
Copy link
 #5

Actions
Copy link

Also available in: PDF Atom