Project

General

Profile

Actions

Security #5025

closed
SB JI

ftp: GetLine function buffers data indefinitely if 0x0a was not found int the frag'd input

Security #5025: ftp: GetLine function buffers data indefinitely if 0x0a was not found int the frag'd input

Added by Shivani Bhardwaj about 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Label:
CVE:
Git IDs:

9f10e338108bc26ec53af6d5ac53126d06f723e5
b2da5e86ea9315ad876e50bb95dcb8be70f959b5

Severity:
MODERATE
Disclosure Date:

Description

We tend to execute


           ptmp = FTPRealloc(line_state->db, line_state->db_len,
                             (line_state->db_len + state->input_len));
            if (ptmp == NULL) {
                FTPFree(line_state->db, line_state->db_len);
                line_state->db = NULL;
                line_state->db_len = 0; 
                return -1;
            }
            line_state->db = ptmp;

            memcpy(line_state->db + line_state->db_len,
                   state->input, state->input_len);
            line_state->db_len += state->input_len;
        }    
        state->input += state->input_len;
        state->input_len = 0; 

indefinitely.


Related issues 1 (0 open1 closed)

Copied from Suricata - Security #5024: ftp: GetLine function buffers data indefinitely if 0x0a was not found int the frag'd inputClosedJason IshActions

SB Updated by Shivani Bhardwaj about 4 years ago Actions #1

  • Copied from Security #5024: ftp: GetLine function buffers data indefinitely if 0x0a was not found int the frag'd input added

SB Updated by Shivani Bhardwaj about 4 years ago Actions #2

  • Assignee changed from Shivani Bhardwaj to Jeff Lucovsky

The fix will have to be backported from 6.0.x and not master

JI Updated by Jason Ish about 4 years ago Actions #3

  • Related to Bug #5235: ftp: add event when command request or response is too long added

JI Updated by Jason Ish about 4 years ago Actions #4

  • Related to deleted (Bug #5235: ftp: add event when command request or response is too long)

JI Updated by Jason Ish about 4 years ago Actions #5

  • Assignee changed from Jeff Lucovsky to Jason Ish

JI Updated by Jason Ish about 4 years ago Actions #6

  • Status changed from Assigned to In Review

VJ Updated by Victor Julien about 4 years ago Actions #7

  • Status changed from In Review to Resolved

Fix staged.

VJ Updated by Victor Julien about 4 years ago Actions #8

  • Tracker changed from Bug to Security
  • Severity set to MODERATE

JI Updated by Jason Ish about 4 years ago Actions #9

  • Status changed from Resolved to Closed
  • Git IDs updated (diff)

VJ Updated by Victor Julien over 3 years ago Actions #10

  • Private changed from Yes to No
Actions

Also available in: PDF Atom