Project

General

Profile

Actions

Optimization #5123

closed

Bug #5124: alerts: 5.0.8/6.0.4 count noalert sigs towards built-in alert limit (5.0.x backport)

alerts: use alert queing in DetectEngineThreadCtx (5.0.x backport)

Added by Jeff Lucovsky about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

Currently each alert is written directly to Packet::alerts during rule evaluation. Then at the end of the detection run for a packet, PacketAlertFinalize removes entries again, when applying thresholding, suppression and noalert. This leads to the issue in #4941 but is often also not very efficient esp when there are multiple rules to remove.

The idea of this ticket is to use a per DetectEngineThreadCtx specific queue of some sort to store the alert "candidates" and have PacketAlertFinalize only write the final alerts to the Packet structure.


Related issues 2 (0 open2 closed)

Related to Suricata - Optimization #5178: detect/alert: improve packet alert queue handlingRejectedJuliana Fajardini ReichowActions
Copied from Suricata - Optimization #4943: alerts: use alert queing in DetectEngineThreadCtxClosedJuliana Fajardini ReichowActions
Actions #1

Updated by Jeff Lucovsky about 2 years ago

Actions #2

Updated by Juliana Fajardini Reichow about 2 years ago

Actions #3

Updated by Juliana Fajardini Reichow almost 2 years ago

  • Assignee changed from OISF Dev to Juliana Fajardini Reichow
  • Target version set to 5.0.10
Actions #4

Updated by Juliana Fajardini Reichow almost 2 years ago

  • Status changed from New to In Progress
Actions #5

Updated by Juliana Fajardini Reichow almost 2 years ago

  • Status changed from In Progress to In Review
Actions #6

Updated by Juliana Fajardini Reichow almost 2 years ago

  • Subject changed from alerts: use alert queing in DetectEngineThreadCtx to alerts: use alert queing in DetectEngineThreadCtx (5.0.x backport)
Actions #7

Updated by Victor Julien almost 2 years ago

  • Parent task changed from #5120 to #5124
Actions #8

Updated by Juliana Fajardini Reichow almost 2 years ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF