Optimization #5517
closeddecode: big clean up (macros and functions)
Description
decode.h seems to have some unused macros, functions that could replace macros, as well as functions that are named similarly than macros, but have slightly different behaviors.
I think it would be beneficial to go over the file and remove unused code and replace macros for functions when possible.
An interesting example is the PACKET_SET_ACTION macro - we have a PacketSetAction function which calls the macro, but takes into account packet tunneling - which doesn't seem to be accounted for in the corresponding macro.
JF Updated by Juliana Fajardini Reichow over 3 years ago
I think that this https://github.com/OISF/suricata/pull/8030/commits/9e534e91175284e4fd70b5f85437b36798de754a#diff-48e701cfe9e2223cedaa68c2dad70955a5b41c803cc1a3feba33d75a18d35533 addresses most of the things this issue was supposed to cover.
JF Updated by Juliana Fajardini Reichow over 3 years ago
- Target version changed from TBD to 8.0.0-beta1
VJ Updated by Victor Julien about 2 years ago
- Assignee changed from Juliana Fajardini Reichow to OISF Dev
VJ Updated by Victor Julien almost 2 years ago
- Status changed from New to In Progress
- Assignee changed from OISF Dev to Victor Julien
VJ Updated by Victor Julien almost 2 years ago
- Status changed from In Progress to In Review
VJ Updated by Victor Julien almost 2 years ago
- Status changed from In Review to Closed