Project

General

Profile

Actions

Bug #5629

closed

windivert compile fails on 7.0.0-beta1

Added by Peter Manev over 1 year ago. Updated 11 months ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Target version:
-
Affected Versions:
Effort:
Difficulty:
Label:

Description

The compile without WinDivert works fine.

  CC       source-pfring.o
  CC       source-windivert.o
source-windivert.c: In function 'WinDivertInitQPCValues':
source-windivert.c:218:5: error: implicit declaration of function 'TimeGet' [-Werror=implicit-function-declaration]
  218 |     TimeGet(&now);
      |     ^~~~~~~
source-windivert.c: In function 'ReceiveWinDivertThreadInit':
source-windivert.c:201:35: error: implicit declaration of function 'Win32GetErrorString'; did you mean 'mciGetErrorString'? [-Werror=implicit-function-declaration]
  201 |         const char *win_err_str = Win32GetErrorString((err_code), NULL);       \
      |                                   ^~~~~~~~~~~~~~~~~~~
source-windivert.c:201:35: note: in definition of macro 'WinDivertLogError'
  201 |         const char *win_err_str = Win32GetErrorString((err_code), NULL);       \
      |                                   ^~~~~~~~~~~~~~~~~~~
source-windivert.c:201:35: warning: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  201 |         const char *win_err_str = Win32GetErrorString((err_code), NULL);       \
      |                                   ^~~~~~~~~~~~~~~~~~~
source-windivert.c:201:35: note: in definition of macro 'WinDivertLogError'
  201 |         const char *win_err_str = Win32GetErrorString((err_code), NULL);       \
      |                                   ^~~~~~~~~~~~~~~~~~~
source-windivert.c: In function 'WinDivertCollectFilterDevices':
source-windivert.c:589:24: error: implicit declaration of function 'Win32GetAdaptersAddresses' [-Werror=implicit-function-declaration]
  589 |     DWORD err = (DWORD)Win32GetAdaptersAddresses(&if_info_list);
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~
source-windivert.c: In function 'WinDivertVerdictHelper':
source-windivert.c:201:35: warning: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  201 |         const char *win_err_str = Win32GetErrorString((err_code), NULL);       \
      |                                   ^~~~~~~~~~~~~~~~~~~
source-windivert.c:201:35: note: in definition of macro 'WinDivertLogError'
  201 |         const char *win_err_str = Win32GetErrorString((err_code), NULL);       \
      |                                   ^~~~~~~~~~~~~~~~~~~
  CC       stream.o
cc1.exe: some warnings being treated as errors
make[2]: *** [Makefile:3464: source-windivert.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/Administrator/suricata-7.0.0-beta1/src'
make[1]: *** [Makefile:2667: all] Error 2
make[1]: Leaving directory '/home/Administrator/suricata-7.0.0-beta1/src'
make: *** [Makefile:489: all-recursive] Error 1


Related issues 1 (0 open1 closed)

Has duplicate Suricata - Bug #5627: windows: windivert build brokenClosedVictor JulienActions
Actions #1

Updated by Victor Julien over 1 year ago

  • Target version changed from TBD to 7.0.0-rc1
  • Affected Versions 7.0.0-beta1 added
  • Affected Versions deleted (7.0.0-rc2)
Actions #2

Updated by Victor Julien over 1 year ago

  • Has duplicate Bug #5627: windows: windivert build broken added
Actions #3

Updated by Victor Julien over 1 year ago

  • Subject changed from windivert compile fails on 7.0.0. beta1 to windivert compile fails on 7.0.0-beta1
Actions #4

Updated by Victor Julien over 1 year ago

  • Label Needs backport to 6.0 added
Actions #5

Updated by Victor Julien over 1 year ago

  • Label deleted (Needs backport to 6.0)

Only an issue in 7

Actions #6

Updated by Victor Julien about 1 year ago

  • Target version changed from 7.0.0-rc1 to 7.0.0-rc2
Actions #7

Updated by Victor Julien about 1 year ago

  • Priority changed from Normal to High
Actions #8

Updated by Victor Julien 11 months ago

  • Status changed from New to Rejected
  • Assignee deleted (OISF Dev)
  • Priority changed from High to Normal
  • Target version deleted (7.0.0-rc2)

Duplicate of #5627

Actions

Also available in: Atom PDF