Project

General

Profile

Actions

Security #5712

closed

tcp: crafted packets lead to resource starvation

Added by Victor Julien almost 2 years ago. Updated 2 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Label:
CVE:
Git IDs:
Severity:
HIGH
Disclosure Date:

Description

The TCP window can be up to 1GiB in size when wscale=14 and window=0xffff. If client and server agree on this, or if an attacker is able to inject packets with these properties to the IDS/IPS, packets within this window will be accepted.

Using just a few packets this scenario can lead to massive memory use:

1. 3whs agrees on wscale=14
2. packet on the right edge of the window comes in, so at almost 1GiB from the ISN, but still in window
3. stream buffer implementation alloc'd a buffer for the entire sequence space, so 1GiB.

To make things worse, if the evil client/server then ACK's this packet, another packet can be sent at an offset of 1GiB and now the memory region will be expanded to 2GiB. This trick can be done on both directions, so it's possible to consume several gigabytes of memory using just a handful of small packets.

Limiting factors:
- stream.reassembly.depth limits this, but is unlimited by default on some protocols like SMB
- stream.reassembly.memcap limits these extreme numbers by default, but its still trivial to consume smaller amounts and exhaust the memcap

The root cause is that the streaming buffer implementation unconditionally aims to create a continues block of reassembled data in memory. This works well is regular and slightly lossy traffic, but not in this case.

Note that #4580 appears to be a related problem with the same root cause, but it happens organically in high speed setups.

Also related is #5703. If pushed enough, the buffer logic will cause a crash. EDIT: This seems not the case. Can't push it beyond 3GiB per direction. ACKs are needed for moving the window forward, but also trigger a slide/trim.


Related issues 2 (0 open2 closed)

Related to Suricata - Bug #4580: smb: large streams can cause large memory moves (memmove)ClosedVictor JulienActions
Related to Suricata - Security #5703: smb: crash inside of streaming buffer Grow()ClosedVictor JulienActions
Actions #1

Updated by Victor Julien almost 2 years ago

  • Related to Bug #4580: smb: large streams can cause large memory moves (memmove) added
Actions #2

Updated by Victor Julien almost 2 years ago

  • Related to Security #5703: smb: crash inside of streaming buffer Grow() added
Actions #3

Updated by Victor Julien almost 2 years ago

  • Description updated (diff)
Actions #4

Updated by Victor Julien almost 2 years ago

  • Description updated (diff)
Actions #5

Updated by Victor Julien almost 2 years ago

  • Status changed from Assigned to In Progress
Actions #6

Updated by Shivani Bhardwaj almost 2 years ago

Is the solution to such a problem that
1. we alloc the buffer as and when the data arrives while checking if we are exceeding the window size? or,
2. we check if we might exceed the window size from stream_offset before reallocing and discard the rest of the stream and label it as a possible attack?
something else?

Actions #7

Updated by Shivani Bhardwaj almost 2 years ago

  • Subtask #5792 added
Actions #8

Updated by Shivani Bhardwaj almost 2 years ago

  • Label deleted (Needs backport to 6.0)
Actions #9

Updated by Victor Julien over 1 year ago

  • Status changed from In Progress to Resolved
Actions #10

Updated by Victor Julien over 1 year ago

  • Subtask deleted (#5792)
Actions #11

Updated by Victor Julien over 1 year ago

  • Status changed from Resolved to Closed
Actions #12

Updated by Victor Julien 2 days ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF