Bug #5809: smb: convert transaction list to vecdeque (6.0.x backport) - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #5809

closed

smb: convert transaction list to vecdeque (6.0.x backport)

Added by Shivani Bhardwaj almost 2 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Normal

Assignee:

Philippe Antoine

Target version:

6.0.13

Affected Versions:

Effort:

Difficulty:

Label:

Actions

Copy link

Updated by Philippe Antoine almost 2 years ago

Do we really want a backport fhere ?
For instance, the DNS VecDeque has not been backported, (commit 31894147884af3e7151b4d653e5268a0b0477db8 in master)
There is only one protocol where VecDeque has been back ported : MQTT...

Actions

Copy link

Updated by Victor Julien almost 2 years ago

Target version changed from 6.0.10 to 6.0.11

Actions

Copy link

Updated by Philippe Antoine almost 2 years ago

So, do you think we should backport all protocols ? (I would reject this for 6)

Actions

Copy link

Updated by Victor Julien almost 2 years ago

Needs a bit more discussion. For now I just moved it out of the 6.0.10.

Wrt whether we should, I guess it comes down to cost, benefit and risk. Cost would be dev time and possible negative overall perf impact, benefit is fairly obvious and risk would be about regressions.

Actions

Copy link