Project

General

Profile

Actions
Copy link

Bug #5809

closed

smb: convert transaction list to vecdeque (6.0.x backport)

Added by Shivani Bhardwaj over 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Philippe Antoine
Target version:
6.0.13
Affected Versions:
Effort:
Difficulty:
Label:
Actions
Copy link
 #1

Updated by Philippe Antoine over 1 year ago

Do we really want a backport fhere ?
For instance, the DNS VecDeque has not been backported, (commit 31894147884af3e7151b4d653e5268a0b0477db8 in master)
There is only one protocol where VecDeque has been back ported : MQTT...

Actions
Copy link
 #2

Updated by Victor Julien over 1 year ago

  • Target version changed from 6.0.10 to 6.0.11
Actions
Copy link
 #3

Updated by Philippe Antoine over 1 year ago

So, do you think we should backport all protocols ? (I would reject this for 6)

Actions
Copy link
 #4

Updated by Victor Julien over 1 year ago

Needs a bit more discussion. For now I just moved it out of the 6.0.10.

Wrt whether we should, I guess it comes down to cost, benefit and risk. Cost would be dev time and possible negative overall perf impact, benefit is fairly obvious and risk would be about regressions.

Actions
Copy link
 #5

Updated by Victor Julien over 1 year ago

  • Parent task deleted (#5753)
Actions
Copy link
 #6

Updated by Philippe Antoine about 1 year ago

So @Victor Julien , should this be done for 6.0.11 ?

Actions
Copy link
 #7

Updated by Philippe Antoine about 1 year ago

  • Target version changed from 6.0.11 to 6.0.12
Actions
Copy link
 #8

Updated by Victor Julien 12 months ago

  • Target version changed from 6.0.12 to 6.0.13
Actions
Copy link
 #9

Updated by Philippe Antoine 11 months ago

  • Status changed from Assigned to In Review
Actions
Copy link
 #10

Updated by Philippe Antoine 11 months ago

  • Status changed from In Review to Closed
Actions
Copy link
 #11

Updated by Victor Julien 10 months ago

  • Private changed from Yes to No
Actions
Copy link

Also available in: Atom PDF