Project

General

Profile

Actions
Copy link

Bug #5818

closed
JL JL

time: integer comparison with different signs

Bug #5818: time: integer comparison with different signs

Added by Jeff Lucovsky about 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jeff Lucovsky
Target version:
7.0.0-rc2
Affected Versions:
Effort:
Difficulty:
Label:

Description

Using SCTime instead of timeval has created the following issue:

source-pfring.c: In function 'ReceivePfringLoop':
source-pfring.c:425:36: warning: comparison of integer expressions of different signedness: 'long unsigned int' and 'time_t' {aka 'long int'} [-Wsign-compare]
  425 |             if (SCTIME_SECS(p->ts) != last_dump) {

Subtasks 1 (0 open — 1 closed)

Bug #6034: time: integer comparison with different signs (6.0.x backport)ClosedJeff LucovskyActions

Related issues 1 (0 open — 1 closed)

Has duplicate Suricata - Bug #3090: pfring compile err - openSUSE Tumbleweed , Ubuntu Eoan/ Debian unstableClosedActions

VJ Updated by Victor Julien about 3 years ago Actions
Copy link
 #1

  • Target version changed from 7.0.0-beta1 to 7.0.0-rc1

VJ Updated by Victor Julien about 3 years ago Actions
Copy link
 #2

  • Target version changed from 7.0.0-rc1 to 7.0.0-rc2

JL Updated by Jeff Lucovsky about 3 years ago Actions
Copy link
 #3

  • Status changed from Assigned to In Review

JL Updated by Jeff Lucovsky about 3 years ago Actions
Copy link
 #4

  • Status changed from In Review to Closed

VJ Updated by Victor Julien about 3 years ago Actions
Copy link
 #5

  • Status changed from Closed to Assigned

Another case

source-nflog.c: In function ‘NFLOGCallback’:                         
source-nflog.c:181:36: warning: passing argument 2 of ‘nflog_get_timestamp’ from incompatible pointer type [-Wincompatible-pointer-types]
  181 |     ret = nflog_get_timestamp(nfa, &p->ts);                 
      |                                    ^~~~~~         
      |                                    |
      |                                    SCTime_t * {aka struct <anonymous> *}
In file included from source-nflog.h:28,                 
                 from decode.h:68,
                 from source-nflog.c:27:                     
/usr/include/libnetfilter_log/libnetfilter_log.h:57:73: note: expected ‘struct timeval *’ but argument is of type ‘SCTime_t *’ {aka ‘struct <anonymous> *’}
   57 | extern int nflog_get_timestamp(struct nflog_data *nfad, struct timeval *tv);
      |                                                         ~~~~~~~~~~~~~~~~^~

JL Updated by Jeff Lucovsky about 3 years ago Actions
Copy link
 #6

  • Status changed from Assigned to In Review

JL Updated by Jeff Lucovsky about 3 years ago Actions
Copy link
 #7

  • Status changed from In Review to Closed

JL Updated by Jeff Lucovsky almost 3 years ago Actions
Copy link
 #8

  • Status changed from Closed to Resolved
  • Label Needs backport to 6.0 added

OT Updated by OISF Ticketbot almost 3 years ago Actions
Copy link
 #9

  • Subtask #6034 added

OT Updated by OISF Ticketbot almost 3 years ago Actions
Copy link
 #10

  • Label deleted (Needs backport to 6.0)

VJ Updated by Victor Julien almost 3 years ago Actions
Copy link
 #11

  • Has duplicate Bug #3090: pfring compile err - openSUSE Tumbleweed , Ubuntu Eoan/ Debian unstable added

VJ Updated by Victor Julien almost 3 years ago Actions
Copy link
 #12

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: PDF Atom