Bug #5818: time: integer comparison with different signs - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #5818

closed

time: integer comparison with different signs

Added by Jeff Lucovsky almost 2 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Normal

Assignee:

Jeff Lucovsky

Target version:

7.0.0-rc2

Affected Versions:

Effort:

Difficulty:

Label:

Description

Using SCTime instead of timeval has created the following issue:

source-pfring.c: In function 'ReceivePfringLoop':
source-pfring.c:425:36: warning: comparison of integer expressions of different signedness: 'long unsigned int' and 'time_t' {aka 'long int'} [-Wsign-compare]
  425 |             if (SCTIME_SECS(p->ts) != last_dump) {

Subtasks 1 (0 open — 1 closed)

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Victor Julien almost 2 years ago

Target version changed from 7.0.0-beta1 to 7.0.0-rc1

Actions

Copy link

Updated by Victor Julien almost 2 years ago

Target version changed from 7.0.0-rc1 to 7.0.0-rc2

Actions

Copy link

Updated by Jeff Lucovsky almost 2 years ago

Status changed from Assigned to In Review

https://github.com/OISF/suricata/pull/8487

Actions

Copy link

Updated by Jeff Lucovsky almost 2 years ago

Status changed from In Review to Closed

Actions

Copy link

Updated by Victor Julien almost 2 years ago

Status changed from Closed to Assigned

Another case

source-nflog.c: In function ‘NFLOGCallback’:                         
source-nflog.c:181:36: warning: passing argument 2 of ‘nflog_get_timestamp’ from incompatible pointer type [-Wincompatible-pointer-types]
  181 |     ret = nflog_get_timestamp(nfa, &p->ts);                 
      |                                    ^~~~~~         
      |                                    |
      |                                    SCTime_t * {aka struct <anonymous> *}
In file included from source-nflog.h:28,                 
                 from decode.h:68,
                 from source-nflog.c:27:                     
/usr/include/libnetfilter_log/libnetfilter_log.h:57:73: note: expected ‘struct timeval *’ but argument is of type ‘SCTime_t *’ {aka ‘struct <anonymous> *’}
   57 | extern int nflog_get_timestamp(struct nflog_data *nfad, struct timeval *tv);
      |                                                         ~~~~~~~~~~~~~~~~^~

Actions

Copy link