Bug #5818
closed
time: integer comparison with different signs
Added by Jeff Lucovsky over 1 year ago.
Updated 12 months ago.
Description
Using SCTime instead of timeval has created the following issue:
source-pfring.c: In function 'ReceivePfringLoop':
source-pfring.c:425:36: warning: comparison of integer expressions of different signedness: 'long unsigned int' and 'time_t' {aka 'long int'} [-Wsign-compare]
425 | if (SCTIME_SECS(p->ts) != last_dump) {
- Target version changed from 7.0.0-beta1 to 7.0.0-rc1
- Target version changed from 7.0.0-rc1 to 7.0.0-rc2
- Status changed from Assigned to In Review
- Status changed from In Review to Closed
- Status changed from Closed to Assigned
Another case
source-nflog.c: In function ‘NFLOGCallback’:
source-nflog.c:181:36: warning: passing argument 2 of ‘nflog_get_timestamp’ from incompatible pointer type [-Wincompatible-pointer-types]
181 | ret = nflog_get_timestamp(nfa, &p->ts);
| ^~~~~~
| |
| SCTime_t * {aka struct <anonymous> *}
In file included from source-nflog.h:28,
from decode.h:68,
from source-nflog.c:27:
/usr/include/libnetfilter_log/libnetfilter_log.h:57:73: note: expected ‘struct timeval *’ but argument is of type ‘SCTime_t *’ {aka ‘struct <anonymous> *’}
57 | extern int nflog_get_timestamp(struct nflog_data *nfad, struct timeval *tv);
| ~~~~~~~~~~~~~~~~^~
- Status changed from Assigned to In Review
- Status changed from In Review to Closed
- Status changed from Closed to Resolved
- Label Needs backport to 6.0 added
- Label deleted (
Needs backport to 6.0)
- Has duplicate Bug #3090: pfring compile err - openSUSE Tumbleweed , Ubuntu Eoan/ Debian unstable added
- Status changed from Resolved to Closed
Also available in: Atom
PDF