Project

General

Profile

Actions

Bug #5905

closed

invalid bsize and distance rule being loaded by suricata

Added by Philippe Antoine almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

Found by oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=56067&q=label%3AProj-suricata

Reproducer is drop ip :: 0 <> :: 4 ipv6.hdr;bsize:8;content:" ";disTance:-5;content:" ";disTance:-020000000000;

It gets to a signed integer overflow with detect-content.c:452:19: runtime error: signed integer overflow: -4 + -2147483647 cannot be represented in type 'int'

Somehow introduced by #2982 fix https://github.com/OISF/suricata/pull/8124 but I guess the root cause existed before

I guess one part of the fix is to use precise integer types for arguments of SigParseRequiredContentSize


Related issues 2 (0 open2 closed)

Related to Suricata - Bug #5740: content: within and distance lengths should be boundedClosedJeff LucovskyActions
Related to Suricata - Bug #2982: invalid dsize distance rule being loaded by suricataClosedJeff LucovskyActions
Actions #1

Updated by Philippe Antoine almost 2 years ago

  • Subject changed from invalid dsize and distance rule being loaded by suricata to invalid bsize and distance rule being loaded by suricata
Actions #2

Updated by Philippe Antoine almost 2 years ago

  • Related to Bug #5740: content: within and distance lengths should be bounded added
Actions #3

Updated by Philippe Antoine almost 2 years ago

  • Related to Bug #2982: invalid dsize distance rule being loaded by suricata added
Actions #4

Updated by Jeff Lucovsky almost 2 years ago

  • Status changed from Assigned to In Review
Actions #5

Updated by Jeff Lucovsky over 1 year ago

  • Status changed from In Review to Closed
Actions #6

Updated by Victor Julien over 1 year ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF