Project

General

Custom queries

Profile

Actions

Bug #5980

closed

rust: warning for future compile errors

Added by Victor Julien over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

   Compiling suricata v6.0.11-dev (/home/victor/suricata/rust)
    Finished release [optimized + debuginfo] target(s) in 2m 07s
warning: the following packages contain code that will be rejected by a future version of Rust: nom v5.1.1
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3`

The issue seems to be some kind of trivial parsing change in Rust:

> warning: trailing semicolon in macro used in expression position
>    --> /home/victor/.cargo/registry/src/github.com-1ecc6299db9ec823/nom-5.1.1/src/combinator/macros.rs:509:35
>     |
> 509 |     map!(__impl $i, call!($f), $g);
>     |                                   ^
>     |
>    ::: /home/victor/.cargo/registry/src/github.com-1ecc6299db9ec823/nom-5.1.1/src/number/complete.rs:595:3
>     |
> 595 |   map!(i, le_u128, |x| x as i128)
>     |   ------------------------------- in this macro invocation
>     |
>     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
>     = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
>     = note: macro invocations at the end of a block are treated as expressions
>     = note: to ignore the value produced by the macro, add a semicolon after the invocation of `map`
>     = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default
>     = note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)

We'll have to see if we can work around this somehow.

Actions #1

Updated by Victor Julien over 1 year ago

  • Status changed from Assigned to Closed
Actions

Also available in: Atom PDF