Project

General

Profile

Actions

Task #6326

closed

Task #2975: convert unittests to new FAIL/PASS API

Convert unittests to new FAIL/PASS API - detect-ssh-software-version.c

Added by Juliana Fajardini Reichow about 1 year ago. Updated 5 months ago.

Status:
Rejected
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:
Beginner, C, Good First Issue, Outreachy

Description

Follow the instructions from the parent task to know how to convert them.


Related issues 3 (2 open1 closed)

Related to Suricata - Feature #2377: deprecate: ssh.softwareversion and ssh.protoversionClosedPhilippe AntoineActions
Copied from Suricata - Task #6325: Convert unittests to new FAIL/PASS API - detect-urilen.cNewCommunity TicketActions
Copied to Suricata - Task #6327: Convert unittests to new FAIL/PASS API - threads.cNewCommunity TicketActions
Actions #1

Updated by Juliana Fajardini Reichow about 1 year ago

  • Copied from Task #6325: Convert unittests to new FAIL/PASS API - detect-urilen.c added
Actions #2

Updated by Juliana Fajardini Reichow about 1 year ago

  • Copied to Task #6327: Convert unittests to new FAIL/PASS API - threads.c added
Actions #3

Updated by Temi Yusuf about 1 year ago

Hello community I will like to claim this ticket and work on it.

Actions #4

Updated by Juliana Fajardini Reichow about 1 year ago

Temi Yusuf wrote in #note-3:

Hello community I will like to claim this ticket and work on it.

Hi Temi, I'm assigning the ticket to you, feel free to start working on the task! Let us know if you have any questions :)

Actions #5

Updated by Juliana Fajardini Reichow about 1 year ago

  • Assignee changed from Community Ticket to Temi Yusuf
Actions #6

Updated by Temi Yusuf about 1 year ago

thank You, how can I get started please ? Am I to fork the suricata repo and look for the detect-ssh-software-version.c file ? I am a little confused.

Actions #7

Updated by Juliana Fajardini Reichow about 1 year ago

Temi Yusuf wrote in #note-6:

thank You, how can I get started please ? Am I to fork the suricata repo and look for the detect-ssh-software-version.c file ? I am a little confused.

Yes, the first step is to fork your suricata repository, then create a branch (read more at https://docs.suricata.io/en/latest/devguide/codebase/contributing/contribution-process.html#create-your-own-branch), and then you can follow up the instructions for the task on the parent issue for this task.

You will work with the detect-ssh-software-version.c file, as you've guessed :)

Actions #8

Updated by Juliana Fajardini Reichow about 1 year ago

  • Status changed from New to Assigned
Actions #9

Updated by Daniel Olatunji about 1 year ago

Can I take up this task? Since the Assignee did not continue on with it.

And seems to be AWOL.

Actions #10

Updated by Juliana Fajardini Reichow about 1 year ago

Daniel Olatunji wrote in #note-9:

Can I take up this task? Since the Assignee did not continue on with it.

And seems to be AWOL.

Although that seems to be the case, I'd like to wait for the proper deadline before un-claiming it (see https://forum.suricata.io/t/important-outreachy-contribution-phase-wrap-up-prs-claimed-tickets-and-more/), or unless @Temi Yusuf says they won't be working on it, before that. ;)

If you'd like to work on some beginner-level tasks but don't know where more to look for those, let us know!

Actions #11

Updated by Daniel Olatunji about 1 year ago

Can I take up this task? Since the Assignee did not continue on with it.

And seems to be AWOL.

Juliana Fajardini Reichow wrote in #note-10:

Daniel Olatunji wrote in #note-9:

Can I take up this task? Since the Assignee did not continue on with it.

And seems to be AWOL.

Although that seems to be the case, I'd like to wait for the proper deadline before un-claiming it (see https://forum.suricata.io/t/important-outreachy-contribution-phase-wrap-up-prs-claimed-tickets-and-more/), or unless @Temi Yusuf says they won't be working on it, before that. ;)

If you'd like to work on some beginner-level tasks but don't know where more to look for those, let us know!

I can work on others, Thank you.

Actions #12

Updated by Juliana Fajardini Reichow almost 1 year ago

  • Assignee changed from Temi Yusuf to Community Ticket

Hi there, according to our guidelines for stale tickets, I'm unassigning this ticket.

Thanks for your interest in our project, and feel free to reach out in case you have time and want to contribute to Suricata again! :) :)

Refer to:
https://forum.suricata.io/t/important-outreachy-contribution-phase-wrap-up-prs-claimed-tickets-and-more
https://docs.suricata.io/en/latest/devguide/codebase/contributing/contribution-process.html#stale-tickets-policy

Actions #13

Updated by Juliana Fajardini Reichow almost 1 year ago

  • Status changed from Assigned to New
Actions #14

Updated by Victor Julien 5 months ago

  • Target version changed from 8.0.0-beta1 to TBD
Actions #15

Updated by Philippe Antoine 5 months ago

  • Status changed from New to Rejected

Superseded by #2377

Actions #16

Updated by Philippe Antoine 5 months ago

  • Related to Feature #2377: deprecate: ssh.softwareversion and ssh.protoversion added
Actions

Also available in: Atom PDF