Task #6340
closedTask #2975: convert unittests to new FAIL/PASS API
Convert unittests to new FAIL/PASS API - tests/detect-http-method.c
Description
There are some remaining unittests that were not converted to the FAIL/PASS API in the tests/detect-http-method.c .
Follow the instructions from the parent task to know how to convert them.
Updated by Juliana Fajardini Reichow about 2 years ago
- Copied from Task #6316: Convert unittests to new FAIL/PASS API - app-layer-detect-proto.c added
Updated by Juliana Fajardini Reichow about 2 years ago
- Copied to Task #6341: Convert unittests to new FAIL/PASS API - decode-ethernet.c added
Updated by Victor Julien over 1 year ago
- Target version changed from 8.0.0-beta1 to TBD
Updated by Adetoye Anointing about 1 year ago
Juliana Fajardini Reichow wrote:
There are some remaining unittests that were not converted to the FAIL/PASS API in the tests/detect-http-method.c .
Follow the instructions from the parent task to know how to convert them.
I am also interested in this, how can I get assigned
Updated by Shivani Bhardwaj about 1 year ago
> I am also interested in this, how can I get assigned
You've been granted the Developer role. You can set yourself as Assignee. Please select only one ticket to work on at one time.
Updated by Olusegun Fajobi 15 days ago
- Assignee changed from Community Ticket to Olusegun Fajobi
Updated by Olusegun Fajobi 15 days ago
- Assignee changed from Olusegun Fajobi to Community Ticket
Updated by Jhonny Sousa 12 days ago
I am interested in this issue, can I get assigned to this one?
Updated by Juliana Fajardini Reichow 12 days ago
Jhonny Sousa wrote in #note-8:
I am interested in this issue, can I get assigned to this one?
Hi Jhonny, I just granted you developer role, you should be able to claim the ticket now. Thanks for taking time to work on this issue! :)
Updated by Jhonny Sousa 12 days ago
- Assignee changed from Community Ticket to Jhonny Sousa
Updated by Victor Julien 12 days ago
I think https://github.com/OISF/suricata/pull/14015/commits/5c02dd8963dd955ee11b5c4a140850421f41948d already did most or all of this.
Updated by Jhonny Sousa 12 days ago
Victor Julien wrote in #note-11:
I think https://github.com/OISF/suricata/pull/14015/commits/5c02dd8963dd955ee11b5c4a140850421f41948d already did most or all of this.
Thanks for letting me know about the existing PR! I appreciate the heads-up.
Should I re-assign the ticket to the PR's author (your user) since a PR for it already exists? Or just leave as Community Ticket and move on to another issue?
Updated by Jhonny Sousa 12 days ago
- Assignee changed from Jhonny Sousa to Community Ticket
Updated by Juliana Fajardini Reichow 12 days ago
- Assignee changed from Community Ticket to Victor Julien
Jhonny Sousa wrote in #note-12:
Victor Julien wrote in #note-11:
I think https://github.com/OISF/suricata/pull/14015/commits/5c02dd8963dd955ee11b5c4a140850421f41948d already did most or all of this.
Thanks for letting me know about the existing PR! I appreciate the heads-up.
Should I re-assign the ticket to the PR's author (your user) since a PR for it already exists? Or just leave as Community Ticket and move on to another issue?
I'll assign it to Victor, to make it easier for all.
Sorry about the confusion, I should have noticed which file this ticket was about.
Updated by Juliana Fajardini Reichow 12 days ago
- Status changed from New to In Review
- Target version changed from TBD to 9.0.0
Updated by Victor Julien 12 days ago
- Status changed from In Review to Closed
- Target version changed from 9.0.0 to 9.0.0-beta1