Project

General

Profile

Actions

Optimization #6786

closed

util-rohash.c : make code cleaner to make CodeQL happier

Added by Philippe Antoine about 1 year ago. Updated 25 days ago.

Status:
Closed
Priority:
Low
Assignee:
Target version:
Effort:
Difficulty:
Label:
C, Good First Issue, Hardening

Description

ROHashTable *table = SCMalloc(sizeof(ROHashTable) + size);

We should make ROHashTable struct to match what we are allocating

So, that we get a direct access tot he fiels instead of hacky ROHashTableOffsets *os = (void *)table + sizeof(ROHashTable);

https://github.com/OISF/suricata/security/code-scanning/229 to https://github.com/OISF/suricata/security/code-scanning/233

Actions #1

Updated by Philippe Antoine 7 months ago

  • Label C, Good First Issue, Hardening added
Actions #2

Updated by Philippe Antoine 25 days ago

  • Status changed from New to Closed
  • Target version changed from TBD to 8.0.0-beta1

Fixed by @Victor Julien with 60e6d1d77dd41ff7d349b485e413d6e4b918793e

Actions

Also available in: Atom PDF