Project

General

Profile

Actions

Bug #6839

open

coverity: warning in port grouping code

Added by Victor Julien about 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description


** CID 1592992:  Incorrect expression  (COPY_PASTE_ERROR)
/src/util-port-interval-tree.c: 255 in SCPortIntervalFindOverlaps()

________________________________________________________________________________________________________
*** CID 1592992:  Incorrect expression  (COPY_PASTE_ERROR)
/src/util-port-interval-tree.c: 255 in SCPortIntervalFindOverlaps()
249                      * will be sorted, insert any new ports to the end of the list
250                      * and avoid walking the entire list */
251                     if (*list == NULL) {
252                         *list = new_port;
253                         (*list)->last = new_port;
254                     } else if (((*list)->last->port != new_port->port) &&
>>>     CID 1592992:  Incorrect expression  (COPY_PASTE_ERROR)
>>>     "port" in "(*list)->last->port2 != new_port->port" looks like a copy-paste error.
255                                ((*list)->last->port2 != new_port->port)) {
256                         DEBUG_VALIDATE_BUG_ON(new_port->port < (*list)->last->port);
257                         (*list)->last->next = new_port;
258                         new_port->prev = (*list)->last;
259                         (*list)->last = new_port;
260                     } else {

Subtasks 1 (1 open0 closed)

Bug #6845: coverity: warning in port grouping code (7.0.x backport)In ReviewShivani BhardwajActions
Actions #1

Updated by Victor Julien about 2 months ago

Please review if the code is correct. If it is, we can add a suppression.

Actions #2

Updated by Shivani Bhardwaj about 2 months ago

Victor Julien wrote in #note-1:

Please review if the code is correct. If it is, we can add a suppression.

I think it is but we can safely fix the warning as the case when this can happen port == port2 anyway

Actions #3

Updated by Shivani Bhardwaj about 2 months ago

  • Status changed from Assigned to In Review
Actions #4

Updated by Shivani Bhardwaj about 2 months ago

  • Status changed from In Review to Resolved
  • Label Needs backport to 7.0 added
Actions #5

Updated by OISF Ticketbot about 2 months ago

  • Subtask #6845 added
Actions #6

Updated by OISF Ticketbot about 2 months ago

  • Label deleted (Needs backport to 7.0)
Actions

Also available in: Atom PDF