Project

General

Profile

Actions
Copy link

Optimization #7002

closed

detect: move pseudo packet checks out of keyword Match funcs

Added by Victor Julien 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Victor Julien
Target version:
8.0.0-beta1
Effort:
Difficulty:
Label:

Description

A couple of keywords can only match against real packets, so they check against the PKT_IS_PSEUDOPKT macro.

While a cheap check, this seems unnecessary to do in the Match funcs.

Related issues 2 (0 open — 2 closed)

Related to Suricata - Optimization #6728: detect: prefilter for events (decode, stream, app-layer, etc...)ClosedPhilippe AntoineActions
Related to Suricata - Bug #6291: Performance degradation on Suricata devices with a small number of rulesClosedCole DishingtonActions
Actions
Copy link
 #1

Updated by Philippe Antoine 3 months ago

  • Status changed from In Progress to In Review
Actions
Copy link
 #2

Updated by Philippe Antoine 3 months ago

  • Related to Optimization #6728: detect: prefilter for events (decode, stream, app-layer, etc...) added
Actions
Copy link
 #3

Updated by Philippe Antoine 3 months ago

  • Related to Bug #6291: Performance degradation on Suricata devices with a small number of rules added
Actions
Copy link
 #4

Updated by Victor Julien 3 months ago

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: Atom PDF