Project

General

Profile

Actions
Copy link

Optimization #7352

closed
PA OD

Remove disable-hashing command line option

Optimization #7352: Remove disable-hashing command line option

Added by Philippe Antoine over 1 year ago. Updated 10 months ago.

Status:
Rejected
Priority:
Normal
Assignee:
OISF Dev
Target version:
TBD
Effort:
Difficulty:
Label:

Description

It comes from f723dc1309a793f6fbcf81d6507fe946b4caa04a :

The idea with a flag to disable hashing is to provide a way to

get the effect of building Suricata without libnss, which is
sometimes done for performance reasons.

We do not have nss anymore...

The only other occurrence of nss I find in the code is in util-file.h comment about includes and rust

PA Updated by Philippe Antoine over 1 year ago Actions
Copy link
 #1

  • Status changed from New to In Review
  • Target version changed from 8.0.0-beta1 to TBD

PA Updated by Philippe Antoine over 1 year ago Actions
Copy link
 #2

Also disable-hashing is incomplete : hassh, quic cyu, datasets and more use hashes and are not disabled by the option

PA Updated by Philippe Antoine over 1 year ago Actions
Copy link
 #3

  • Assignee changed from Philippe Antoine to OISF Dev

JI Updated by Jason Ish over 1 year ago Actions
Copy link
 #4

Philippe Antoine wrote in #note-2:

Also disable-hashing is incomplete : hassh, quic cyu, datasets and more use hashes and are not disabled by the option

Ticket should probably be updated to make sure --disable-hashing is respected.

@Victor Julien Any thoughts on keeping this flag around and why?

PA Updated by Philippe Antoine 10 months ago Actions
Copy link
 #5

  • Status changed from In Review to Rejected

The goal was controversial

Actions
Copy link

Also available in: PDF Atom