Bug #7856
closedDPDK EAL options defined in suricata.yaml are not accepted by suricata during startup
Description
Suricata in DPDK run mode can configure the DPDK Environment Abstraction Layer (EAL) using the dpdk.eal-params option defined in suricata.yaml. The commit 4dfd44d changed how the EAL options are parsed and effectively disabled passing the parameters to the rte_eal_init() function. The issue was caused by decreasing the size argument passed to strlcat in AllocAndSetOption within runmode-dpdk.c, trancating every option by one character. The fix was to revert to the original approach by adding + 1 to the size.
Updated by Adam Kiripolsky 23 days ago
- Status changed from In Progress to Resolved
Updated by Lukas Sismis 16 days ago
- Status changed from Resolved to Closed
To Adam -- when your ticket is merged (not staged to merge), please link the PR and close the ticket.
Merged: https://github.com/OISF/suricata/pull/13737
Thank you!
Updated by Lukas Sismis 16 days ago
To add:
We use state Resolved only for tickets that need to be backported to the older versions; each ticket is for a specific version only.
So you have 2 tickets regarding the same issue. You first need to merge into master branch, you set your master-targetting ticket as resolved, you merge the cherry-picked (from the master branch) backport to e.g., suricata-v7 branch, and then you can close both tickets linking the respective PRs.