Project

General

Profile

Actions

Bug #8052

closed
AD AD

python/Makefile: too open file permissions for defaults.py

Bug #8052: python/Makefile: too open file permissions for defaults.py

Added by Andreas Dolp 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
low
Difficulty:
Label:
Python

Description

Hey Suricata folks,
during Debian packaging I tried to resolve a lintian warning 'executable-not-elf-or-script' [1] for the file usr/lib/suricata/python/suricata/config/defaults.py in DEB package version 1:8.0.1-3 (forky sid).

The install command, by default, sets 0755 if -m is not specified [2], so the file python/suricata/config/defaults.py will be marked as an executable, though it isn't.
In my understanding, this is caused by the missing -m 0644 and lintian just reports the problem, so I would like to fix this upstream if you agree. We merged this patch in the next, currently unreleased DEB package release, which fixes the warning. Tests seem to be OK, as this file should never be executed directly.

Will hand in a Github PR soon and link it to this ticket.

Thanks for your reply!
Andreas

[1] https://udd.debian.org/lintian-tag/executable-not-elf-or-script
[2] https://manpages.debian.org/trixie/coreutils/install.1.en.html#m


Subtasks 1 (0 open1 closed)

Bug #8053: python/Makefile: too open file permissions for defaults.py (8.0.x backport)ClosedVictor JulienActions

JI Updated by Jason Ish 5 months ago Actions #2

  • Assignee set to Andreas Dolp
  • Target version changed from TBD to 9.0.0-beta1
  • Label Needs backport to 8.0 added

JI Updated by Jason Ish 5 months ago Actions #3

  • Status changed from New to In Review

OT Updated by OISF Ticketbot 5 months ago Actions #4

  • Subtask #8053 added

OT Updated by OISF Ticketbot 5 months ago Actions #5

  • Label deleted (Needs backport to 8.0)

SB Updated by Shivani Bhardwaj 5 months ago Actions #6

  • Subject changed from python/Makefile.am: fix file permissions of python/suricata/config/defaults.py to python/Makefile: too open file permissions for defaults.py

VJ Updated by Victor Julien 5 months ago Actions #7

  • Status changed from In Review to Resolved

VJ Updated by Victor Julien 5 months ago Actions #8

  • Status changed from Resolved to Closed
Actions

Also available in: PDF Atom