Project

General

Profile

Actions

Bug #8052

closed

python/Makefile: too open file permissions for defaults.py

Added by Andreas Dolp about 1 month ago. Updated 28 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
low
Difficulty:
Label:
Python

Description

Hey Suricata folks,
during Debian packaging I tried to resolve a lintian warning 'executable-not-elf-or-script' [1] for the file usr/lib/suricata/python/suricata/config/defaults.py in DEB package version 1:8.0.1-3 (forky sid).

The install command, by default, sets 0755 if -m is not specified [2], so the file python/suricata/config/defaults.py will be marked as an executable, though it isn't.
In my understanding, this is caused by the missing -m 0644 and lintian just reports the problem, so I would like to fix this upstream if you agree. We merged this patch in the next, currently unreleased DEB package release, which fixes the warning. Tests seem to be OK, as this file should never be executed directly.

Will hand in a Github PR soon and link it to this ticket.

Thanks for your reply!
Andreas

[1] https://udd.debian.org/lintian-tag/executable-not-elf-or-script
[2] https://manpages.debian.org/trixie/coreutils/install.1.en.html#m


Subtasks 1 (0 open1 closed)

Bug #8053: python/Makefile: too open file permissions for defaults.py (8.0.x backport)ClosedVictor JulienActions
Actions #2

Updated by Jason Ish about 1 month ago

  • Assignee set to Andreas Dolp
  • Target version changed from TBD to 9.0.0-beta1
  • Label Needs backport to 8.0 added
Actions #3

Updated by Jason Ish about 1 month ago

  • Status changed from New to In Review
Actions #4

Updated by OISF Ticketbot about 1 month ago

  • Subtask #8053 added
Actions #5

Updated by OISF Ticketbot about 1 month ago

  • Label deleted (Needs backport to 8.0)
Actions #6

Updated by Shivani Bhardwaj about 1 month ago

  • Subject changed from python/Makefile.am: fix file permissions of python/suricata/config/defaults.py to python/Makefile: too open file permissions for defaults.py
Actions #7

Updated by Victor Julien 29 days ago

  • Status changed from In Review to Resolved
Actions #8

Updated by Victor Julien 28 days ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF