Project

General

Profile

Actions
Copy link

Task #8595

open
SB SB

flowbits: remove "toggle" command

Task #8595: flowbits: remove "toggle" command

Added by Shivani Bhardwaj 22 days ago. Updated 6 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Shivani Bhardwaj
Target version:
9.0.0-beta1
Effort:
Difficulty:
low
Label:

Description

flowbits toggle command is not used by any major ruleset provider.
All the functionality that toggle offers can already be achieved by the combination of other available commands that are in regular use.
State tracking for flowbits becomes a bit simplified if one of the commands is removed.

Subtasks 2 (2 open — 0 closed)

Task #8638: flowbits: deprecate "toggle" commandIn ReviewShivani BhardwajActions
Task #8639: flowbits: deprecate "toggle" commandIn ReviewShivani BhardwajActions

SB Updated by Shivani Bhardwaj 22 days ago Actions
Copy link
 #1

  • Subject changed from flowbits: deprecated "toggle" command to flowbits: deprecate "toggle" command

SB Updated by Shivani Bhardwaj 22 days ago Actions
Copy link
 #2

  • Difficulty set to low

SB Updated by Shivani Bhardwaj 22 days ago Actions
Copy link
 #3

  • Status changed from Assigned to In Review

PA Updated by Philippe Antoine 16 days ago Actions
Copy link
 #4

All the functionality that toggle offers can already be achieved by the combination of other available commands that are in regular use.

I am not sure it is the case. How do you handle this ?

I am not in favor of deprecating this feature directly.

State tracking for flowbits becomes a bit simplified if one of the commands is removed.

We could just print a warning when this command is used and not do the state tracking...

SB Updated by Shivani Bhardwaj 7 days ago Actions
Copy link
 #5

  • Status changed from In Review to Closed

VJ Updated by Victor Julien 7 days ago Actions
Copy link
 #6

How is adding the notices to 7 and 8 tracked?

SB Updated by Shivani Bhardwaj 6 days ago Actions
Copy link
 #7

I'll create a tracking ticket for that. Realizing this ticket's title is wrong. 8 and 7 should use "deprecated" and this one should be about the removal altogether.

SB Updated by Shivani Bhardwaj 6 days ago Actions
Copy link
 #8

  • Subject changed from flowbits: deprecate "toggle" command to flowbits: remove "toggle" command

SB Updated by Shivani Bhardwaj 6 days ago Actions
Copy link
 #9

  • Status changed from Closed to Resolved

SB Updated by Shivani Bhardwaj 6 days ago Actions
Copy link
 #10

  • Subtask #8638 added

SB Updated by Shivani Bhardwaj 6 days ago Actions
Copy link
 #11

  • Subtask #8639 added
Actions
Copy link

Also available in: PDF Atom