Task #8595
closedflowbits: remove "toggle" command
Description
flowbits toggle command is not used by any major ruleset provider.
All the functionality that toggle offers can already be achieved by the combination of other available commands that are in regular use.
State tracking for flowbits becomes a bit simplified if one of the commands is removed.
SB Updated by Shivani Bhardwaj about 1 month ago
- Subject changed from flowbits: deprecated "toggle" command to flowbits: deprecate "toggle" command
SB Updated by Shivani Bhardwaj about 1 month ago
- Difficulty set to low
SB Updated by Shivani Bhardwaj about 1 month ago
- Status changed from Assigned to In Review
In Review PR: https://github.com/OISF/suricata/pull/15443
PA Updated by Philippe Antoine about 1 month ago
All the functionality that toggle offers can already be achieved by the combination of other available commands that are in regular use.
I am not sure it is the case. How do you handle this ?
I am not in favor of deprecating this feature directly.
State tracking for flowbits becomes a bit simplified if one of the commands is removed.
We could just print a warning when this command is used and not do the state tracking...
SB Updated by Shivani Bhardwaj 28 days ago
- Status changed from In Review to Closed
Closed by: https://github.com/OISF/suricata/pull/15567
VJ Updated by Victor Julien 28 days ago
How is adding the notices to 7 and 8 tracked?
SB Updated by Shivani Bhardwaj 26 days ago
I'll create a tracking ticket for that. Realizing this ticket's title is wrong. 8 and 7 should use "deprecated" and this one should be about the removal altogether.
SB Updated by Shivani Bhardwaj 26 days ago
- Subject changed from flowbits: deprecate "toggle" command to flowbits: remove "toggle" command
SB Updated by Shivani Bhardwaj 26 days ago
- Status changed from Closed to Resolved
SB Updated by Shivani Bhardwaj 26 days ago
- Subtask #8638 added
SB Updated by Shivani Bhardwaj 26 days ago
- Subtask #8639 added
PA Updated by Philippe Antoine 11 days ago
- Status changed from Resolved to Closed