Project

General

Profile

Actions

Security #9182

closed
JI PA

doh2: DNS inspection progress type confusion remains on 8.0.x

Security #9182: doh2: DNS inspection progress type confusion remains on 8.0.x

Added by Jason Ish about 1 month ago. Updated 3 days ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Label:
CVE:
Git IDs:

712aa5279ff3ae61ce28325353724f039dcc7bcd

Severity:
MODERATE
Disclosure Date:

Description

The 8.0.x backport for Redmine #8916, tracked as Redmine #8920, is incomplete. DoH2 DNS inspection can still pass an embedded DNSTransaction * to the HTTP/2 progress callback, causing an out-of-bounds read.

Current main is not affected because its DoH2 inspection model includes commit 5735b87c3 (detect: change how DOH2 inspection works). That commit is not present on 8.0.x.

References

  • Redmine #8916: original issue
  • Redmine #8920: incomplete 8.0.x backport
  • Redmine #8386 / commit 5735b87c3: main-only DoH2 inspection rework
  • Main fix commit 5284906338
  • 8.0.x backport commit 321308f503

Related issues 2 (0 open — 2 closed)

Related to Suricata - Security #9117: doh2: evasion if DNS query is sent in DATA frame without END_STREAMClosedPhilippe AntoineActions
Related to Suricata - Security #8920: doh: dns inspection uses the wrong transaction for progress (8.0.x backport)ClosedPhilippe AntoineActions

JI Updated by Jason Ish about 1 month ago Actions #1

  • Status changed from New to In Review

MR on GL.

JI Updated by Jason Ish about 1 month ago Actions #2

  • Related to Security #9117: doh2: evasion if DNS query is sent in DATA frame without END_STREAM added

JI Updated by Jason Ish about 1 month ago Actions #3

  • Assignee changed from Jason Ish to Philippe Antoine

JI Updated by Jason Ish about 1 month ago Actions #4

To be combined with #9117.

PA Updated by Philippe Antoine about 1 month ago Actions #5

  • Related to Security #8920: doh: dns inspection uses the wrong transaction for progress (8.0.x backport) added

JI Updated by Jason Ish about 1 month ago Actions #6

  • GHSA set to GHSA-p38h-39j7-hffp

JI Updated by Jason Ish 28 days ago Actions #7

  • Severity set to MODERATE

MODERATE per the GHSA, and the previous fix (#8920).

VJ Updated by Victor Julien 21 days ago Actions #8

  • Status changed from In Review to Resolved

JI Updated by Jason Ish 20 days ago Actions #9

  • Git IDs updated (diff)

PA Updated by Philippe Antoine 20 days ago Actions #10

  • Status changed from Resolved to Closed

JI Updated by Jason Ish 3 days ago Actions #11

  • Private changed from Yes to No
Actions

Also available in: PDF Atom