Actions
Bug #9265
closed
VJ
VJ
nfs: v4 COMPOUND records misparsed, or missing or misattributed in EVE
Bug #9265:
nfs: v4 COMPOUND records misparsed, or missing or misattributed in EVE
Affected Versions:
Effort:
Difficulty:
Label:
Description
Description¶
Several NFSv4 COMPOUND records are misparsed, or leave a missing or misattributed record in EVE:
- OPEN4args: the claim is read as a word plus a name whatever its type. CLAIM_FH and CLAIM_DELEG_PREV_FH carry nothing, CLAIM_PREVIOUS carries a delegation type, and CLAIM_DELEGATE_CUR and CLAIM_DELEG_CUR_FH carry a stateid. The open owner's XDR pad and the fattr4 after an EXCLUSIVE4_1 verifier are not consumed. Every later op of the compound misparses and the logged filename is wrong.
- OPEN reply with a delegation: the nfsace4
whois consumed without its XDR pad andnfs_space_limit4is read 4 bytes short. A SEQUENCE result is skipped as a fixed-size blob. - A COMPOUND whose first op cannot be parsed, and an RPCSEC_GSS integrity call that cannot be unwrapped, only set an event on the newest transaction. When the flow has none, nothing is logged. On a reply the event marks the newest transaction instead of the one owning the xid.
- NFS records completed by flow-end pseudo packets are logged in flow direction, the others in packet direction, so one flow logs transactions under both.
Expected behaviour¶
OPEN arguments and replies are parsed per RFC 7530 and RFC 8881. A record that cannot be parsed gets a transaction of its own with a malformed-data event, and appears in EVE. Every NFS record is logged in flow direction, as SMB, HTTP and DNS do.
Affected versions¶
main.
Possible fix¶
Parse the OPEN claim union by its type and the delegation and SEQUENCE results per field; give a rejected or un-walkable record its own transaction; normalise every NFS record on the flow direction.
JI Updated by Jason Ish 19 days ago
- Status changed from In Review to Resolved
- Label Needs backport to 8.0 added
Merged with https://github.com/OISF/suricata/pull/16529.
OT Updated by OISF Ticketbot 19 days ago
- Subtask #9297 added
OT Updated by OISF Ticketbot 19 days ago
- Label deleted (
Needs backport to 8.0)
JI Updated by Jason Ish about 4 hours ago
- Private changed from Yes to No
Actions