Project

General

Profile

Actions
Copy link

Bug #1315

closed

trans_q should not have hardcoded size

Added by Ken Steele over 9 years ago. Updated about 5 years ago.

Status:
Rejected
Priority:
Low
Assignee:
OISF Dev
Target version:
-
Affected Versions:
Effort:
Difficulty:
Label:

Description

The PacketQueue trans_q256 in suricata.h is always indexed by tv->inq->id, where Tmq* inq->id is assigned in tm-queues.c. inq->id is not checked to be not larger than TMC_MAX_QUEUES. So suricata.h should define trans_q as:

PacketQueue trans_q[TMC_MAX_QUEUES];

This will require moving the #define for TMC_MAX_QUEUES to tm-queues.h, which is where is should really be anyway.

Related issues 1 (0 open — 1 closed)

Is duplicate of Suricata - Optimization #947: dynamic allocation of thread queuesClosedVictor JulienActions
Actions
Copy link
 #1

Updated by Andreas Herz about 8 years ago

  • Assignee set to OISF Dev
  • Target version set to TBD
Actions
Copy link
 #2

Updated by Victor Julien almost 6 years ago

Actions
Copy link
 #3

Updated by Victor Julien almost 6 years ago

  • Status changed from New to Rejected

Duplicate of #947

Actions
Copy link
 #4

Updated by Victor Julien about 5 years ago

  • Target version deleted (TBD)
Actions
Copy link

Also available in: Atom PDF