Project

General

Profile

Optimization #2878

Catch control-c (KeyboardInterrupt) and exit cleanly.

Added by Jason Ish 12 days ago. Updated 7 days ago.

Status:
Feedback
Priority:
Low
Assignee:
-
Target version:
-
Effort:
low
Difficulty:
low
Label:
Beginner, Outreachy

Description

Right now if you hit control-c, suricata-update will exit (as expected) but display a traceback of what was currently being executed. This could be made more friendly by catching the "KeyboardInterrupt" and simply displaying a message like:

Program interrupted by keyboard, aborting.

But still exit with an error code 1.

History

#1

Updated by Shivani Bhardwaj 11 days ago

  • Status changed from New to Feedback
  • Assignee deleted (Shivani Bhardwaj)
#2

Updated by Saira Hussain 7 days ago

Jason Ish wrote:

Right now if you hit control-c, suricata-update will exit (as expected) but display a traceback of what was currently being executed. This could be made more friendly by catching the "KeyboardInterrupt" and simply displaying a message like:
[...]
But still exit with an error code 1.

I would like to get this ticket for my Outreachy approval stage ;)

#3

Updated by Saira Hussain 7 days ago

I did sent a PR [here](https://github.com/OISF/suricata-update/pull/117), happy waiting for reviews!

#4

Updated by Saira Hussain 7 days ago

Saira Hussain wrote:

I did sent a PR here: https://github.com/OISF/suricata-update/pull/117, happy waiting for reviews!

Also available in: Atom PDF