Project

General

Profile

Actions

Optimization #2878

closed

Catch control-c (KeyboardInterrupt) and exit cleanly.

Added by Jason Ish over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Low
Target version:
Effort:
low
Difficulty:
low
Label:
Beginner, Outreachy

Description

Right now if you hit control-c, suricata-update will exit (as expected) but display a traceback of what was currently being executed. This could be made more friendly by catching the "KeyboardInterrupt" and simply displaying a message like:

Program interrupted by keyboard, aborting.

But still exit with an error code 1.

Actions #1

Updated by Shivani Bhardwaj over 2 years ago

  • Status changed from New to Feedback
  • Assignee deleted (Shivani Bhardwaj)
Actions #2

Updated by Saira Hussain over 2 years ago

Jason Ish wrote:

Right now if you hit control-c, suricata-update will exit (as expected) but display a traceback of what was currently being executed. This could be made more friendly by catching the "KeyboardInterrupt" and simply displaying a message like:
[...]
But still exit with an error code 1.

I would like to get this ticket for my Outreachy approval stage ;)

Actions #3

Updated by Saira Hussain over 2 years ago

I did sent a PR [here](https://github.com/OISF/suricata-update/pull/117), happy waiting for reviews!

Actions #4

Updated by Saira Hussain over 2 years ago

Saira Hussain wrote:

I did sent a PR here: https://github.com/OISF/suricata-update/pull/117, happy waiting for reviews!

Actions #5

Updated by Andreas Herz over 2 years ago

  • Assignee set to Community Ticket
Actions #6

Updated by Shivani Bhardwaj over 2 years ago

  • Status changed from Feedback to Resolved
  • Target version set to Soon
Actions #8

Updated by Shivani Bhardwaj about 2 years ago

  • Status changed from Resolved to Closed
Actions #9

Updated by Jason Ish about 2 years ago

  • Target version changed from Soon to 1.1.0rc1
Actions

Also available in: Atom PDF