Project

General

Profile

Actions

Optimization #2878

closed
JI CT

Catch control-c (KeyboardInterrupt) and exit cleanly.

Optimization #2878: Catch control-c (KeyboardInterrupt) and exit cleanly.

Added by Jason Ish about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Low
Target version:
Effort:
low
Difficulty:
low
Label:
Beginner, Outreachy

Description

Right now if you hit control-c, suricata-update will exit (as expected) but display a traceback of what was currently being executed. This could be made more friendly by catching the "KeyboardInterrupt" and simply displaying a message like:

Program interrupted by keyboard, aborting.

But still exit with an error code 1.

SB Updated by Shivani Bhardwaj about 7 years ago Actions #1

  • Status changed from New to Feedback
  • Assignee deleted (Shivani Bhardwaj)

SH Updated by Saira Hussain about 7 years ago Actions #2

Jason Ish wrote:

Right now if you hit control-c, suricata-update will exit (as expected) but display a traceback of what was currently being executed. This could be made more friendly by catching the "KeyboardInterrupt" and simply displaying a message like:
[...]
But still exit with an error code 1.

I would like to get this ticket for my Outreachy approval stage ;)

SH Updated by Saira Hussain about 7 years ago Actions #3

I did sent a PR [here](https://github.com/OISF/suricata-update/pull/117), happy waiting for reviews!

SH Updated by Saira Hussain about 7 years ago Actions #4

Saira Hussain wrote:

I did sent a PR here: https://github.com/OISF/suricata-update/pull/117, happy waiting for reviews!

AH Updated by Andreas Herz almost 7 years ago Actions #5

  • Assignee set to Community Ticket

SB Updated by Shivani Bhardwaj almost 7 years ago Actions #6

  • Status changed from Feedback to Resolved
  • Target version set to TBD

SB Updated by Shivani Bhardwaj over 6 years ago Actions #8

  • Status changed from Resolved to Closed

JI Updated by Jason Ish over 6 years ago Actions #9

  • Target version changed from TBD to 1.1.0rc1
Actions

Also available in: PDF Atom