Project

General

Profile

Bug #3072

Rust nightly warning

Added by Philippe Antoine 17 days ago. Updated 5 days ago.

Status:
Assigned
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

Using rustc 1.37.0-nightly (0beb2ba16 2019-07-02) for compiling suricata, I got two new warnings

warning: `...` range patterns are deprecated
   --> src/smb/dcerpc.rs:364:19
    |
364 |                 21...255 => {
    |                   ^^^ help: use `..=` for an inclusive range
    |
    = note: #[warn(ellipsis_inclusive_range_patterns)] on by default

warning: `...` range patterns are deprecated
   --> src/smb/dcerpc.rs:482:11
    |
482 |         21...255 => {
    |           ^^^ help: use `..=` for an inclusive range

warning: variable does not need to be mutable
   --> src/dhcp/parser.rs:202:17
    |
202 |             let mut malformed_options = false;
    |                 ----^^^^^^^^^^^^^^^^^
    |                 |
    |                 help: remove this `mut`
    |
    = note: #[warn(unused_mut)] on by default

Fix must work with the minimal rustc version (1.24) supported by Suricata


Related issues

Has duplicate Bug #3088: rust warning for dhcp on Ubuntu Bionic/EoanClosedActions

History

#1

Updated by Andreas Herz 15 days ago

  • Assignee set to OISF Dev
  • Target version set to TBD
#2

Updated by Victor Julien 5 days ago

  • Status changed from New to Assigned
  • Assignee changed from OISF Dev to Shivani Bhardwaj
  • Target version changed from TBD to 5.0rc1

The 2nd issue is also in 1.36 (https://travis-ci.org/OISF/suricata/jobs/558281973)

Shivani can you take a look?

#3

Updated by Victor Julien 5 days ago

  • Has duplicate Bug #3088: rust warning for dhcp on Ubuntu Bionic/Eoan added

Also available in: Atom PDF