Project

General

Profile

Actions
Copy link

Optimization #3077

closed

FTP parser command lookup

Added by Jeff Lucovsky almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jeff Lucovsky
Target version:
5.0rc1
Effort:
Difficulty:
Label:

Description

The FTP parser should use mpm when looking for commands instead of performing a linear search over the command coordinates with squashed case.

Related issues 1 (0 open — 1 closed)

Related to Suricata - Feature #2315: eve: ftp loggingClosedJeff LucovskyActions
Actions
Copy link
 #1

Updated by Victor Julien almost 5 years ago

  • Status changed from New to Assigned
  • Assignee set to Jeff Lucovsky
  • Target version set to 70
  • Effort deleted (low)
Actions
Copy link
 #2

Updated by Philippe Antoine almost 5 years ago

Actions
Copy link
 #3

Updated by Jeff Lucovsky almost 5 years ago

Also, address this comment from the FTP logging PR https://github.com/OISF/suricata/pull/3967#discussion_r302236153

" Ok. but then could output-json-ftp.c call some new parsing function in app-layer-ftp.c ?
This way, we will defer parsing until needed and the parsing will be in app-*.c files"

Actions
Copy link
 #4

Updated by Jeff Lucovsky over 4 years ago

  • Status changed from Assigned to Closed
Actions
Copy link
 #5

Updated by Victor Julien over 4 years ago

  • Target version changed from 70 to 5.0rc1
Actions
Copy link

Also available in: Atom PDF