Optimization #3524: Remove unsafe Rust code for ALPROTO_X constants - Suricata - Open Information Security Foundation

Actions

Copy link

Optimization #3524

closed

Remove unsafe Rust code for ALPROTO_X constants

Added by Philippe Antoine about 4 years ago. Updated 11 months ago.

Status:

Rejected

Priority:

Normal

Assignee:

Target version:

Effort:

Difficulty:

Label:

Description

Now, these constants are defined in C enumeration `AppProtoEnum`

In Rust, we use a global variable ('`static mut`) whose value we get as a return of a C function call.
As a global variable, we must use `unsafe` every time we read it

We should either :
- export these from C to Rust with bindgen
- move this enum to Rust and export it to C with cbindgen (cbindgen is already used)

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by Nick Price almost 4 years ago

Got started on this - moved the enum to Rust and am exporting it with cbindgen

Looks like there are a few "cyclic header dependencies" that will have to be sorted out - other than that it's just a question of safely accessing/mutating the global variables

Actions

Copy link

Updated by Philippe Antoine almost 4 years ago

Thanks for working on this and letting us know

Actions

Copy link

Updated by Victor Julien almost 4 years ago

Status changed from New to Assigned
Assignee set to Nick Price
Target version set to TBD

Actions

Copy link

Updated by Nick Price almost 4 years ago

Think I've got everything sorted except the header cross-dependencies - once that's done I'll run the test suites and make a PR - hopefully what I did makes sense :P

Actions

Copy link