Project

General

Profile

Actions

Bug #3571

closed

rust: smb compile warnings

Added by Jeff Lucovsky over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

Using latest git

  Compiling snmp-parser v0.5.2
   Compiling suricata v6.0.0-dev (/home/pmanev/qa/test/suricata-git-rctests/suricata/rust)
warning: unnecessary parentheses around block return value
   --> src/smb/smb.rs:708:9
    |
708 | /         (self.rec_type == hdr.rec_type && self.ssn_id == hdr.ssn_id &&
709 | |          self.msg_id == hdr.msg_id)
    | |___________________________________^
    |
    = note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
    |
708 |         self.rec_type == hdr.rec_type && self.ssn_id == hdr.ssn_id &&
709 |          self.msg_id == hdr.msg_id
    |

warning: unnecessary parentheses around block return value
   --> src/smb/detect.rs:154:13
    |
154 |             (them < us)
    |             ^^^^^^^^^^^ help: remove these parentheses

warning: unnecessary parentheses around block return value
   --> src/smb/detect.rs:157:13
    |
157 |             (them > us)
    |             ^^^^^^^^^^^ help: remove these parentheses

warning: unnecessary parentheses around block return value
   --> src/smb/detect.rs:160:13
    |
160 |             (them == us)
    |             ^^^^^^^^^^^^ help: remove these parentheses

warning: unnecessary parentheses around block return value
   --> src/smb/detect.rs:163:13
    |
163 |             (them != us)
    |             ^^^^^^^^^^^^ help: remove these parentheses

    Building [=======================================================> ] 94/95: suricata  

Related issues

Copied from Bug #3529: rust: smb compile warningsClosedVictor JulienActions
Copied to Bug #3572: rust: smb compile warningsClosedShivani BhardwajActions
Actions #1

Updated by Jeff Lucovsky over 1 year ago

  • Copied from Bug #3529: rust: smb compile warnings added
Actions #2

Updated by Jeff Lucovsky over 1 year ago

  • Copied to Bug #3572: rust: smb compile warnings added
Actions #3

Updated by Jeff Lucovsky over 1 year ago

  • Status changed from New to Assigned
Actions #4

Updated by Jeff Lucovsky over 1 year ago

  • Status changed from Assigned to In Review
Actions #5

Updated by Jeff Lucovsky over 1 year ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF