Actions
Bug #3529
closedrust: smb compile warnings
Affected Versions:
Effort:
Difficulty:
Label:
Needs backport
Description
Using latest git
Compiling snmp-parser v0.5.2 Compiling suricata v6.0.0-dev (/home/pmanev/qa/test/suricata-git-rctests/suricata/rust) warning: unnecessary parentheses around block return value --> src/smb/smb.rs:708:9 | 708 | / (self.rec_type == hdr.rec_type && self.ssn_id == hdr.ssn_id && 709 | | self.msg_id == hdr.msg_id) | |___________________________________^ | = note: `#[warn(unused_parens)]` on by default help: remove these parentheses | 708 | self.rec_type == hdr.rec_type && self.ssn_id == hdr.ssn_id && 709 | self.msg_id == hdr.msg_id | warning: unnecessary parentheses around block return value --> src/smb/detect.rs:154:13 | 154 | (them < us) | ^^^^^^^^^^^ help: remove these parentheses warning: unnecessary parentheses around block return value --> src/smb/detect.rs:157:13 | 157 | (them > us) | ^^^^^^^^^^^ help: remove these parentheses warning: unnecessary parentheses around block return value --> src/smb/detect.rs:160:13 | 160 | (them == us) | ^^^^^^^^^^^^ help: remove these parentheses warning: unnecessary parentheses around block return value --> src/smb/detect.rs:163:13 | 163 | (them != us) | ^^^^^^^^^^^^ help: remove these parentheses Building [=======================================================> ] 94/95: suricata
Updated by Peter Manev almost 5 years ago
rustc -V rustc 1.42.0 (b8cedc004 2020-03-09)
Updated by Victor Julien almost 5 years ago
- Status changed from New to Closed
- Assignee set to Victor Julien
- Target version set to 6.0.0beta1
- Label Needs backport added
Updated by Jeff Lucovsky over 4 years ago
- Copied to Bug #3571: rust: smb compile warnings added
Actions