Project

General

Profile

Actions
Copy link

Bug #3783

closed

Stack overflow in DetectFlowbitsAnalyze

Added by Antti Tönkyrä almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Antti Tönkyrä
Target version:
6.0.0beta1
Affected Versions:
Effort:
Difficulty:
Label:
Needs backport to 5.0

Description

When doing torture tests, I discovered a stack overflow in DetectFlowbitsAnalyze. I have made a PR to github @ https://github.com/OISF/suricata/pull/5103

Overflow happens when number of flowbits is sufficiently large which in turn causes array containing FBAnalyze structs to be greater than stack size.

Changeset should apply cleanly to 5.x too.

Related issues 1 (0 open — 1 closed)

Copied to Suricata - Bug #3790: Stack overflow in DetectFlowbitsAnalyzeClosedJeff LucovskyActions
Actions
Copy link
 #1

Updated by Antti Tönkyrä almost 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Antti Tönkyrä almost 4 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Victor Julien almost 4 years ago

  • Status changed from New to In Review
  • Assignee set to Antti Tönkyrä
  • Target version set to 6.0.0beta1
  • Label Needs backport to 5.0 added
Actions
Copy link
 #4

Updated by Antti Tönkyrä almost 4 years ago

  • Description updated (diff)
Actions
Copy link
 #5

Updated by Jeff Lucovsky almost 4 years ago

  • Copied to Bug #3790: Stack overflow in DetectFlowbitsAnalyze added
Actions
Copy link
 #6

Updated by Victor Julien almost 4 years ago

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: Atom PDF