Project

General

Profile

Actions
Copy link

Optimization #3825

closed
PA JF

Defining only one basic rust Files structure

Optimization #3825: Defining only one basic rust Files structure

Added by Philippe Antoine over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Low
Assignee:
Juliana Fajardini Reichow
Target version:
7.0.0-beta1
Effort:
Difficulty:
Label:
Beginner, Outreachy, Rust

Description

SMBFiles and NFSFiles (and someday HTTP2Files ) are the same

So, there should be only one generic definition
cf https://github.com/OISF/suricata/pull/5122#discussion_r448774401

SB Updated by Shivani Bhardwaj over 5 years ago Actions
Copy link
 #1

  • Assignee changed from Philippe Antoine to Community Ticket
  • Label Beginner, Outreachy, Rust added

JF Updated by Juliana Fajardini Reichow over 5 years ago Actions
Copy link
 #2

  • Assignee changed from Community Ticket to Juliana Fajardini Reichow

JF Updated by Juliana Fajardini Reichow over 5 years ago Actions
Copy link
 #3

  • Assignee changed from Juliana Fajardini Reichow to Community Ticket

JF Updated by Juliana Fajardini Reichow over 5 years ago Actions
Copy link
 #4

  • Assignee changed from Community Ticket to Juliana Fajardini Reichow

JF Updated by Juliana Fajardini Reichow over 5 years ago Actions
Copy link
 #5

  • Status changed from New to In Review

PA Updated by Philippe Antoine over 5 years ago Actions
Copy link
 #6

Thanks Juliana.
Did you already make a Github PR ?
If so, could you post in Redmine the link to the Github PR when you change the status to in review ?

JF Updated by Juliana Fajardini Reichow over 5 years ago Actions
Copy link
 #7

Philippe Antoine wrote in #note-6:

Thanks Juliana.
Did you already make a Github PR ?
If so, could you post in Redmine the link to the Github PR when you change the status to in review ?

Yes, sure! Sorry, I wasn't aware I should do that (although it makes sense, yes). Can you tell me where is the best place to put it?

For now, it's here: https://github.com/OISF/suricata/pull/5513

PA Updated by Philippe Antoine over 5 years ago Actions
Copy link
 #8

Perfect, thanks Juliana

JF Updated by Juliana Fajardini Reichow over 5 years ago Actions
Copy link
 #9

New PR, partially approved, so far:

https://github.com/OISF/suricata/pull/5534

JF Updated by Juliana Fajardini Reichow over 5 years ago Actions
Copy link
 #10

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: PDF Atom