Project

General

Profile

Actions
Copy link

Optimization #3825

closed

Defining only one basic rust Files structure

Added by Philippe Antoine over 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Juliana Fajardini Reichow
Target version:
7.0.0-beta1
Effort:
Difficulty:
Label:
Beginner, Outreachy, Rust

Description

SMBFiles and NFSFiles (and someday HTTP2Files ) are the same

So, there should be only one generic definition
cf https://github.com/OISF/suricata/pull/5122#discussion_r448774401

Actions
Copy link
 #1

Updated by Shivani Bhardwaj about 4 years ago

  • Assignee changed from Philippe Antoine to Community Ticket
  • Label Beginner, Outreachy, Rust added
Actions
Copy link
 #2

Updated by Juliana Fajardini Reichow about 4 years ago

  • Assignee changed from Community Ticket to Juliana Fajardini Reichow
Actions
Copy link
 #3

Updated by Juliana Fajardini Reichow about 4 years ago

  • Assignee changed from Juliana Fajardini Reichow to Community Ticket
Actions
Copy link
 #4

Updated by Juliana Fajardini Reichow about 4 years ago

  • Assignee changed from Community Ticket to Juliana Fajardini Reichow
Actions
Copy link
 #5

Updated by Juliana Fajardini Reichow about 4 years ago

  • Status changed from New to In Review
Actions
Copy link
 #6

Updated by Philippe Antoine about 4 years ago

Thanks Juliana.
Did you already make a Github PR ?
If so, could you post in Redmine the link to the Github PR when you change the status to in review ?

Actions
Copy link
 #7

Updated by Juliana Fajardini Reichow about 4 years ago

Philippe Antoine wrote in #note-6:

Thanks Juliana.
Did you already make a Github PR ?
If so, could you post in Redmine the link to the Github PR when you change the status to in review ?

Yes, sure! Sorry, I wasn't aware I should do that (although it makes sense, yes). Can you tell me where is the best place to put it?

For now, it's here: https://github.com/OISF/suricata/pull/5513

Actions
Copy link
 #8

Updated by Philippe Antoine about 4 years ago

Perfect, thanks Juliana

Actions
Copy link
 #9

Updated by Juliana Fajardini Reichow about 4 years ago

New PR, partially approved, so far:

https://github.com/OISF/suricata/pull/5534

Actions
Copy link
 #10

Updated by Juliana Fajardini Reichow almost 4 years ago

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: Atom PDF