Project

General

Profile

Actions

Optimization #3825

closed

Defining only one basic rust Files structure

Added by Philippe Antoine about 1 year ago. Updated 9 months ago.

Status:
Closed
Priority:
Low
Target version:
Effort:
Difficulty:
Label:
Beginner, Outreachy, Rust

Description

SMBFiles and NFSFiles (and someday HTTP2Files ) are the same

So, there should be only one generic definition
cf https://github.com/OISF/suricata/pull/5122#discussion_r448774401

Actions #1

Updated by Shivani Bhardwaj 11 months ago

  • Assignee changed from Philippe Antoine to Community Ticket
  • Label Beginner, Outreachy, Rust added
Actions #2

Updated by Juliana Fajardini Reichow 11 months ago

  • Assignee changed from Community Ticket to Juliana Fajardini Reichow
Actions #3

Updated by Juliana Fajardini Reichow 11 months ago

  • Assignee changed from Juliana Fajardini Reichow to Community Ticket
Actions #4

Updated by Juliana Fajardini Reichow 11 months ago

  • Assignee changed from Community Ticket to Juliana Fajardini Reichow
Actions #5

Updated by Juliana Fajardini Reichow 11 months ago

  • Status changed from New to In Review
Actions #6

Updated by Philippe Antoine 11 months ago

Thanks Juliana.
Did you already make a Github PR ?
If so, could you post in Redmine the link to the Github PR when you change the status to in review ?

Actions #7

Updated by Juliana Fajardini Reichow 11 months ago

Philippe Antoine wrote in #note-6:

Thanks Juliana.
Did you already make a Github PR ?
If so, could you post in Redmine the link to the Github PR when you change the status to in review ?

Yes, sure! Sorry, I wasn't aware I should do that (although it makes sense, yes). Can you tell me where is the best place to put it?

For now, it's here: https://github.com/OISF/suricata/pull/5513

Actions #8

Updated by Philippe Antoine 11 months ago

Perfect, thanks Juliana

Actions #9

Updated by Juliana Fajardini Reichow 10 months ago

New PR, partially approved, so far:

https://github.com/OISF/suricata/pull/5534

Actions #10

Updated by Juliana Fajardini Reichow 9 months ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF