Project

General

Profile

Optimization #3825

Defining only one basic rust Files structure

Added by Philippe Antoine 12 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Low
Target version:
Effort:
Difficulty:
Label:
Beginner, Outreachy, Rust

Description

SMBFiles and NFSFiles (and someday HTTP2Files ) are the same

So, there should be only one generic definition
cf https://github.com/OISF/suricata/pull/5122#discussion_r448774401

#1

Updated by Shivani Bhardwaj 8 months ago

  • Assignee changed from Philippe Antoine to Community Ticket
  • Label Beginner, Outreachy, Rust added
#2

Updated by Juliana Fajardini Reichow 8 months ago

  • Assignee changed from Community Ticket to Juliana Fajardini Reichow
#3

Updated by Juliana Fajardini Reichow 8 months ago

  • Assignee changed from Juliana Fajardini Reichow to Community Ticket
#4

Updated by Juliana Fajardini Reichow 8 months ago

  • Assignee changed from Community Ticket to Juliana Fajardini Reichow
#5

Updated by Juliana Fajardini Reichow 8 months ago

  • Status changed from New to In Review
#6

Updated by Philippe Antoine 8 months ago

Thanks Juliana.
Did you already make a Github PR ?
If so, could you post in Redmine the link to the Github PR when you change the status to in review ?

#7

Updated by Juliana Fajardini Reichow 8 months ago

Philippe Antoine wrote in #note-6:

Thanks Juliana.
Did you already make a Github PR ?
If so, could you post in Redmine the link to the Github PR when you change the status to in review ?

Yes, sure! Sorry, I wasn't aware I should do that (although it makes sense, yes). Can you tell me where is the best place to put it?

For now, it's here: https://github.com/OISF/suricata/pull/5513

#8

Updated by Philippe Antoine 8 months ago

Perfect, thanks Juliana

#9

Updated by Juliana Fajardini Reichow 8 months ago

New PR, partially approved, so far:

https://github.com/OISF/suricata/pull/5534

#10

Updated by Juliana Fajardini Reichow 7 months ago

  • Status changed from In Review to Closed

Also available in: Atom PDF