Added by Philippe Antoine over 5 years ago. Updated over 5 years ago.
Description
SMBFiles and NFSFiles (and someday HTTP2Files ) are the same
So, there should be only one generic definition
cf https://github.com/OISF/suricata/pull/5122#discussion_r448774401
Thanks Juliana.
Did you already make a Github PR ?
If so, could you post in Redmine the link to the Github PR when you change the status to in review ?
Philippe Antoine wrote in #note-6:
Thanks Juliana.
Did you already make a Github PR ?
If so, could you post in Redmine the link to the Github PR when you change the status to in review ?
Yes, sure! Sorry, I wasn't aware I should do that (although it makes sense, yes). Can you tell me where is the best place to put it?
For now, it's here: https://github.com/OISF/suricata/pull/5513
Perfect, thanks Juliana
New PR, partially approved, so far:
PR merged: https://github.com/OISF/suricata/pull/5534