Project

General

Profile

Actions

Optimization #4141

closed

Task #4143: tracking: file.data improvements

file.data: inspect File objects for HTTP

Added by Victor Julien over 3 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Effort:
Difficulty:
Label:

Description

file.data for HTTP currently inspects the HtpBody instead of File(s). These will usually contain the same data, except for the multipart case.

Switching to File(s) would make the implementation simpler and make the implementation more correct.

David Wharton and Jae Williams have offered to run test runs for their rule collections to validate that this change won't break anything.


Related issues 3 (2 open1 closed)

Related to Suricata - Task #4097: Suricon 2020 brainstormAssignedVictor JulienActions
Related to Suricata - Bug #5868: filestore: not saving files when filestore enabled by rule matching on file_data (instead saves 0 bytes)ClosedJeff LucovskyActions
Related to Suricata - Task #6217: research: increased tcp.overlap after file data changesNewVictor JulienActions
Actions #1

Updated by Victor Julien over 3 years ago

  • Related to Task #4097: Suricon 2020 brainstorm added
Actions #2

Updated by Victor Julien over 3 years ago

  • Parent task set to #4143
Actions #3

Updated by Victor Julien over 3 years ago

A possible optimization after this has been done, is that in most cases we might not need to track the HtpBody separately anymore.

Actions #4

Updated by Victor Julien over 1 year ago

  • Priority changed from Normal to High
  • Target version changed from 7.0.0-beta1 to 7.0.0-rc1
Actions #5

Updated by Victor Julien over 1 year ago

  • Priority changed from High to Normal
  • Target version changed from 7.0.0-rc1 to 8.0.0-beta1
Actions #6

Updated by Jeff Lucovsky about 1 year ago

  • Status changed from Assigned to In Review
Actions #7

Updated by Victor Julien 11 months ago

  • Related to Bug #5868: filestore: not saving files when filestore enabled by rule matching on file_data (instead saves 0 bytes) added
Actions #8

Updated by Victor Julien 11 months ago

  • Target version changed from 8.0.0-beta1 to 7.0.0
Actions #9

Updated by Victor Julien 11 months ago

  • Status changed from In Review to In Progress
  • Target version changed from 7.0.0 to 8.0.0-beta1

Still too much to do, so moving to 8.

Current draft https://github.com/OISF/suricata/pull/9207

Actions #10

Updated by Victor Julien 11 months ago

  • Status changed from In Progress to Closed
  • Target version changed from 8.0.0-beta1 to 7.0.0
Actions #11

Updated by Victor Julien 11 months ago

  • Related to Task #6217: research: increased tcp.overlap after file data changes added
Actions

Also available in: Atom PDF